Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 141 fix external get users not found #147

Conversation

tholudwig
Copy link

@tholudwig tholudwig commented Jan 25, 2024

This fix for #141 and #140 solves some problems in report/customsql/tests/external/external_get_users_test.php

  1. renaming namespace core_external
  2. hardening the output $user->id as int
  3. improve comparison $defaultuserimage
  4. tests run in locked processes because moodle/site:config is loaded (output in the unit tests)

Test instructions

  • Run corresponding unit test --> no errors / comments

@tholudwig tholudwig force-pushed the Issue-141-fix-external_get_users-not-found branch from 867c5e6 to 749dece Compare January 25, 2024 14:37
@tholudwig tholudwig closed this Jan 26, 2024
@tholudwig
Copy link
Author

Hi,

an old version of the plugin was mistakenly checked out in our repo. After a rebase, all unit tests run without errors. The pull request is therefore not necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant