Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable MBIP-5 on Moonriver #2500

Merged
merged 3 commits into from
Oct 6, 2023
Merged

enable MBIP-5 on Moonriver #2500

merged 3 commits into from
Oct 6, 2023

Conversation

ahmadkaouk
Copy link
Contributor

What does it do?

Enable MBIP-5 on moonriver

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

@ahmadkaouk ahmadkaouk added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes labels Sep 22, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2023

Coverage generated "Fri Oct 6 09:06:46 UTC 2023":
https://d3ifz9vhxc2wtb.cloudfront.net/pulls/2500/html/index.html

Master coverage: 87.39%
Pull coverage:

@ahmadkaouk ahmadkaouk marked this pull request as ready for review September 28, 2023 14:21
@ahmadkaouk ahmadkaouk added the D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited label Oct 4, 2023
@ahmadkaouk ahmadkaouk merged commit 3cb70aa into master Oct 6, 2023
24 of 26 checks passed
@ahmadkaouk ahmadkaouk deleted the ahmad-mbip5-moonriver branch October 6, 2023 08:41
@notlesh notlesh added D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited and removed D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants