feat: smart constructor for Json

[peter-jerry-ye]

No description provided.

[peter-jerry-ye-code-review]

‼️ This code review is generated by a bot. Please verify the content before trusting it.

Here are three observations and potential issues from the provided git diff output:

1. Inconsistent Return Statements:

   • In the Json::boolean function, the return statements are implicit (i.e., True and False are used without the return keyword). However, in other functions like Json::null, Json::number, Json::string, Json::array, and Json::object, the return keyword is explicitly used. This inconsistency in style could lead to confusion or readability issues. It would be better to standardize the use of return across all functions.

2. Potential Typo in Example Code:

   • In the Json::array function's example, the array values is initialized with [1.0, "hello"]. However, 1.0 is a Double, and "hello" is a String. This array should contain elements of type Json, but the example does not explicitly wrap these values in Json types (e.g., Json::number(1.0) and Json::string("hello")). This could lead to a type mismatch or confusion for users.

3. Missing Documentation for Json::default:

   • The Json::default function is declared in the impl Json block, but there is no corresponding implementation or documentation in the json.mbt file. This could be an oversight, as the function is part of the public API but lacks clarity on its purpose and usage. Adding documentation or an implementation for Json::default would improve the usability of the code.

These issues should be addressed to ensure consistency, correctness, and clarity in the codebase.

[coveralls]

Pull Request Test Coverage Report for Build 4685

Details

• 0 of 8 (0.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.1%) to 83.101%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
builtin/json.mbt	0	8	0.0%

Totals
Change from base Build 4683:	-0.1%
Covered Lines:	4765
Relevant Lines:	5734

---

💛 - Coveralls

[bobzhang]

I would like to merge this but it is a bit dangerous currently since boolean, array would pollute the builtin namespace, maybe we can wait until the new method mechanism landed cc @Guest0x0