Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove redundant loc in assert_xx function #1604

Merged
merged 3 commits into from
Feb 7, 2025
Merged

fix: remove redundant loc in assert_xx function #1604

merged 3 commits into from
Feb 7, 2025

Conversation

illusory0x0
Copy link
Contributor

@coveralls
Copy link
Collaborator

coveralls commented Feb 7, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 5222

Details

  • 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.804%
Changes Missing Coverage Covered Lines Changed/Added Lines %
builtin/assert.mbt 0 4 0.0%
Totals Coverage Status
Change from base Build 5218: 0.0%
Covered Lines: 5440
Relevant Lines: 6340
💛 - Coveralls

@peter-jerry-ye peter-jerry-ye linked an issue Feb 7, 2025 that may be closed by this pull request
Redundant loc in the assert_eq function #1599
Closed
peter-jerry-ye
peter-jerry-ye approved these changes Feb 7, 2025
View reviewed changes
Copy link
Collaborator

@peter-jerry-ye peter-jerry-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to rerun moon fmt

@peter-jerry-ye peter-jerry-ye enabled auto-merge (rebase) February 7, 2025 06:07
auto-merge was automatically disabled February 7, 2025 06:31

Head branch was pushed to by a user without write access

@bobzhang bobzhang enabled auto-merge (rebase) February 7, 2025 14:41
@bobzhang bobzhang merged commit f987b54 into moonbitlang:main Feb 7, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peter-jerry-ye peter-jerry-ye peter-jerry-ye approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redundant loc in the assert_eq function
4 participants
@illusory0x0 @coveralls @peter-jerry-ye @bobzhang