Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support .map.json for mapping back locations of diagnostics #583

Merged
merged 8 commits into from
Feb 10, 2025
Merged

support .map.json for mapping back locations of diagnostics #583

merged 8 commits into from
Feb 10, 2025

Conversation

hackwaly
Copy link
Contributor

@hackwaly hackwaly commented Feb 5, 2025 •
edited
Loading

Related Issues

  • Related issues: #____

Type of Pull Request

  • Bug fix
  • New feature
    • I have already discussed this feature with the maintainers.
  • Refactor
  • Performance optimization
  • Documentation
  • Other (please describe):

Does this PR change existing behavior?

  • Yes (please describe the changes below)
    • This PR added a new feature for mapping locations of diagnostics back to their source files if locations of diagnostics are in generated MoonBit source files. If there's a xx.map.json alongside a xx.mbt file, then the moon cli will report locations according to xx.map.json instead of just in xx.mbt.
  • No

Does this PR introduce new dependencies?

  • No
  • Yes (please check binary size changes)

Checklist:

  • Tests added/updated for bug fixes or new features
  • Compatible with Windows/Linux/macOS

@hackwaly hackwaly requested a review from Young-Flash February 6, 2025 03:10
@hackwaly hackwaly force-pushed the yuxiang/diag-loc-map branch from 2d660c7 to a79e29b Compare February 6, 2025 03:10
@hackwaly hackwaly marked this pull request as ready for review February 6, 2025 03:11
@hackwaly hackwaly force-pushed the yuxiang/diag-loc-map branch from 392c251 to 5ac44ae Compare February 8, 2025 04:01
@hackwaly hackwaly enabled auto-merge February 8, 2025 04:04
@hackwaly hackwaly disabled auto-merge February 8, 2025 04:05
@hackwaly hackwaly enabled auto-merge February 8, 2025 04:06
@hackwaly hackwaly force-pushed the yuxiang/diag-loc-map branch from 5ac44ae to 83867e4 Compare February 8, 2025 09:08
@hackwaly hackwaly force-pushed the yuxiang/diag-loc-map branch from 83867e4 to 5f5c25d Compare February 10, 2025 07:30
@hackwaly hackwaly added this pull request to the merge queue Feb 10, 2025
Merged via the queue into main with commit 5f5c25d Feb 10, 2025
28 checks passed
@hackwaly hackwaly deleted the yuxiang/diag-loc-map branch February 10, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Young-Flash Young-Flash Young-Flash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hackwaly @Young-Flash