Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: respect IGNORE_DIRS in non-root dirs #591

Merged
merged 1 commit into from
Feb 11, 2025
Merged

fix: respect IGNORE_DIRS in non-root dirs #591

merged 1 commit into from
Feb 11, 2025

Conversation

tonyfettes
Copy link
Contributor

@tonyfettes tonyfettes commented Feb 10, 2025 •
edited
Loading

Related Issues

Type of Pull Request

  • Bug fix
  • New feature
    • I have already discussed this feature with the maintainers.
  • Refactor
  • Performance optimization
  • Documentation
  • Other (please describe):

Does this PR change existing behavior?

  • Yes (please describe the changes below)
    • Before this PR, moon will only ignore directories at root directory. After this PR, moon will ignore directories at every level.
  • No

Does this PR introduce new dependencies?

  • No
  • Yes (please check binary size changes)

Checklist:

  • Tests added/updated for bug fixes or new features
  • Compatible with Windows/Linux/macOS

@Young-Flash Young-Flash added this pull request to the merge queue Feb 11, 2025
Merged via the queue into moonbitlang:main with commit 986655e Feb 11, 2025
27 of 28 checks passed
@tonyfettes tonyfettes deleted the ignore-non-root-dirs branch February 11, 2025 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Young-Flash Young-Flash Young-Flash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

recursive directory (by symlink) cause moon to walk directories forever
2 participants
@tonyfettes @Young-Flash