fix: Support underscore prefixes.

moonrepo · Jul 25, 2023 · 328939d · 328939d
1 parent 6401277
commit 328939d
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/nextgen/common/src/id.rs b/nextgen/common/src/id.rs
@@ -16,7 +16,7 @@ pub static ID_CHARS: &str = r"[0-9A-Za-z/\._-]*";
 
 // The @ is to support npm package scopes!
 pub static ID_PATTERN: Lazy<Regex> =
-    Lazy::new(|| Regex::new(format!("^([A-Za-z@]{{1}}{})$", ID_CHARS).as_str()).unwrap());
+    Lazy::new(|| Regex::new(format!("^([A-Za-z@_]{{1}}{})$", ID_CHARS).as_str()).unwrap());
 
 // This is to clean and ID and remove unwanted characters
 pub static ID_CLEAN: Lazy<Regex> = Lazy::new(|| Regex::new(r"[^0-9A-Za-z/\._-]+").unwrap());

diff --git a/nextgen/target/src/target.rs b/nextgen/target/src/target.rs
@@ -13,7 +13,7 @@ use std::{
 // The @ is to support npm package scopes!
 pub static TARGET_PATTERN: Lazy<Regex> = Lazy::new(|| {
     Regex::new(&format!(
-        r"^(?P<scope>(?:[A-Za-z@#]{{1}}{chars}|\^|~))?:(?P<task>{chars})$",
+        r"^(?P<scope>(?:[A-Za-z@#_]{{1}}{chars}|\^|~))?:(?P<task>{chars})$",
         chars = ID_CHARS
     ))
     .unwrap()

diff --git a/packages/cli/CHANGELOG.md b/packages/cli/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 ## Unreleased
 
+#### 🚀 Updates
+
+- Identifiers (project names, file groups, etc) can now be prefixed with underscores (`_`).
+
 #### 🐞 Fixes
 
 - Fixed an issue where newer moonbase secret keys would fail to sign in.