new: Rework project name/alias querying. (#986)

* Update code. * Update changelog.
moonrepo · Jul 31, 2023 · be8d476 · be8d476
1 parent d93ee21
commit be8d476
Show file tree

Hide file tree

Showing 5 changed files with 27 additions and 11 deletions.
diff --git a/nextgen/project-expander/src/tasks_expander.rs b/nextgen/project-expander/src/tasks_expander.rs
@@ -128,12 +128,9 @@ impl<'graph, 'query> TasksExpander<'graph, 'query> {
                         dep_ids.sort();
 
                         let input = if dep_ids.len() == 1 {
-                            format!("project={id} || projectAlias={id}", id = dep_ids[0])
+                            format!("project={id}", id = dep_ids[0])
                         } else {
-                            format!(
-                                "project=[{ids}] || projectAlias=[{ids}]",
-                                ids = dep_ids.join(",")
-                            )
+                            format!("project=[{ids}]", ids = dep_ids.join(","))
                         };
 
                         for dep_project in (self.context.query)(input)? {
@@ -158,10 +155,8 @@ impl<'graph, 'query> TasksExpander<'graph, 'query> {
                             check_and_push_dep(project, &dep_target.task_id, false)?;
                         }
                     } else {
-                        let results = (self.context.query)(format!(
-                            "project={id} || projectAlias={id}",
-                            id = project_id
-                        ))?;
+                        let results =
+                            (self.context.query)(format!("project={id}", id = project_id))?;
 
                         if results.is_empty() {
                             return Err(TasksExpanderError::UnknownTarget {

diff --git a/nextgen/project/src/project.rs b/nextgen/project/src/project.rs
@@ -93,14 +93,23 @@ impl Queryable for Project {
                 Condition::Field { field, .. } => {
                     let result = match field {
                         Field::Language(langs) => condition.matches_enum(langs, &self.language),
-                        Field::Project(ids) => condition.matches(ids, &self.id),
+                        Field::Project(ids) => {
+                            if condition.matches(ids, &self.id)? {
+                                Ok(true)
+                            } else if let Some(alias) = &self.alias {
+                                condition.matches(ids, alias)
+                            } else {
+                                Ok(false)
+                            }
+                        }
                         Field::ProjectAlias(aliases) => {
                             if let Some(alias) = &self.alias {
                                 condition.matches(aliases, alias)
                             } else {
                                 Ok(false)
                             }
                         }
+                        Field::ProjectName(ids) => condition.matches(ids, &self.id),
                         Field::ProjectSource(sources) => {
                             condition.matches(sources, &self.source.to_string())
                         }

diff --git a/nextgen/query/src/builder.rs b/nextgen/query/src/builder.rs
@@ -10,6 +10,7 @@ pub enum Field {
     Language(Vec<LanguageType>),
     Project(Vec<String>),
     ProjectAlias(Vec<String>),
+    ProjectName(Vec<String>),
     ProjectSource(Vec<String>),
     ProjectType(Vec<ProjectType>),
     Tag(Vec<String>),

diff --git a/packages/cli/CHANGELOG.md b/packages/cli/CHANGELOG.md
@@ -23,6 +23,9 @@
 - **Codegen**
   - Templates can be used as-is without rendering with [Tera](https://tera.netlify.app) by appending
     a `.raw` extension.
+- **Query language**
+  - Updated `project` to query both project name AND alias.
+  - Added `projectName` for only querying by name
 
 #### 🐞 Fixes
 

diff --git a/website/docs/concepts/query-lang.mdx b/website/docs/concepts/query-lang.mdx
@@ -88,7 +88,7 @@ language=rust
 
 ### `project`
 
-ID/name of the project, as defined in [`.moon/workspace.yml`](../config/workspace).
+Name OR alias of the project.
 
 ```
 project=server
@@ -102,6 +102,14 @@ Alias of the project. For example, the `package.json` name.
 projectAlias~@scope/*
 ```
 
+### `projectName`
+
+Name of the project, as defined in [`.moon/workspace.yml`](../config/workspace).
+
+```
+project=server
+```
+
 ### `projectSource`
 
 Relative file path from the workspace root to the project root, as defined in