Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: Move turbo migration into an extension. #1311

Merged
merged 7 commits into from
Feb 3, 2024
Merged

Conversation

milesj
Copy link
Collaborator

@milesj milesj commented Feb 3, 2024

Copy link

github-actions bot commented Feb 3, 2024

Run report for 2dd05660 (ubuntu-latest, 18)

Total time: 3m 21s | Comparison time: 3m 18s | Estimated loss: 3.3s (1.6% slower)

Action Time Status Info
🟩 SyncWorkspace 167.1ms Passed
🟩 SetupNodeTool(18.19.0) 18.9s Passed
🟩 InstallNodeDeps(18.19.0) 49s Passed
🟩 SyncNodeProject(types) 360ms Passed
🟩 SyncNodeProject(runtime) 1.2s Passed
🟦 RunTask(types:build) 1.2s Cached
🟩 SyncNodeProject(website) 1s Passed
🟦 RunTask(runtime:build) 1s Cached
🟩 RunTask(website:build) 2m 10s Passed SLOW
Environment

OS: Linux
Matrix:

os = ubuntu-latest
node-version = 18

Variables:

MOON_NODE_VERSION = 18.19.0
Touched files
Cargo.lock
crates/cli/src/commands/migrate/from_turborepo.rs
crates/cli/src/lib.rs
crates/cli/tests/ext_test.rs
crates/cli/tests/migrate_test.rs
nextgen/config/src/workspace/plugins_config.rs
nextgen/extension-plugin/src/lib.rs
nextgen/pdk-api/Cargo.toml
nextgen/pdk-api/src/extension.rs
nextgen/pdk-api/src/lib.rs
nextgen/pdk-test-utils/Cargo.toml
nextgen/pdk-test-utils/src/lib.rs
nextgen/pdk-test-utils/src/wrappers.rs
nextgen/pdk/Cargo.toml
nextgen/pdk/src/extension.rs
nextgen/pdk/src/lib.rs
nextgen/plugin/Cargo.toml
packages/cli/CHANGELOG.md
tests/fixtures/migrate/turborepo/app/package.json
tests/fixtures/migrate/turborepo/library/package.json
website/blog/2024-02-07_moon-v1.21.mdx
website/docs/commands/migrate/from-turborepo.mdx
website/docs/guides/extensions.mdx

Copy link

github-actions bot commented Feb 3, 2024

Run report for 2dd05660 (ubuntu-latest, 20)

Total time: 2m 54s | Comparison time: 2m 54s | Estimated loss: 519.8ms (0.3% slower)

Action Time Status Info
🟩 SyncWorkspace 218.4ms Passed
🟩 SetupNodeTool(20.11.0) 18.4s Passed
🟩 InstallNodeDeps(20.11.0) 44.5s Passed
🟩 SyncNodeProject(types) 448.3ms Passed
🟩 SyncNodeProject(runtime) 1.1s Passed
🟦 RunTask(types:build) 1.1s Cached
🟩 SyncNodeProject(website) 1s Passed
🟦 RunTask(runtime:build) 1s Cached
🟩 RunTask(website:build) 1m 49s Passed
Environment

OS: Linux
Matrix:

os = ubuntu-latest
node-version = 20

Variables:

MOON_NODE_VERSION = 20.11.0
Touched files
Cargo.lock
crates/cli/src/commands/migrate/from_turborepo.rs
crates/cli/src/lib.rs
crates/cli/tests/ext_test.rs
crates/cli/tests/migrate_test.rs
nextgen/config/src/workspace/plugins_config.rs
nextgen/extension-plugin/src/lib.rs
nextgen/pdk-api/Cargo.toml
nextgen/pdk-api/src/extension.rs
nextgen/pdk-api/src/lib.rs
nextgen/pdk-test-utils/Cargo.toml
nextgen/pdk-test-utils/src/lib.rs
nextgen/pdk-test-utils/src/wrappers.rs
nextgen/pdk/Cargo.toml
nextgen/pdk/src/extension.rs
nextgen/pdk/src/lib.rs
nextgen/plugin/Cargo.toml
packages/cli/CHANGELOG.md
tests/fixtures/migrate/turborepo/app/package.json
tests/fixtures/migrate/turborepo/library/package.json
website/blog/2024-02-07_moon-v1.21.mdx
website/docs/commands/migrate/from-turborepo.mdx
website/docs/guides/extensions.mdx

Copy link

github-actions bot commented Feb 3, 2024

Run report for 2dd05660 (windows-latest, 18)

Total time: 1m 55s | Comparison time: 2m 47s | Estimated savings: 51.5s (30.8% faster)

Action Time Status Info
🟩 SyncWorkspace 152.5ms Passed
🟩 SetupNodeTool(18.19.0) 31s Passed
🟩 InstallNodeDeps(18.19.0) 1m 17s Passed
🟩 SyncNodeProject(types) 303.7ms Passed
🟩 SyncNodeProject(runtime) 470.8ms Passed
🟦 RunTask(types:build) 1.3s Cached
🟩 SyncNodeProject(website) 969.7ms Passed
🟦 RunTask(runtime:build) 966.4ms Cached
🟦 RunTask(website:build) 4.7s Cached
Environment

OS: Windows
Matrix:

os = windows-latest
node-version = 18

Variables:

MOON_NODE_VERSION = 18.19.0
Touched files
Cargo.lock
crates/cli/src/commands/migrate/from_turborepo.rs
crates/cli/src/lib.rs
crates/cli/tests/ext_test.rs
crates/cli/tests/migrate_test.rs
nextgen/config/src/workspace/plugins_config.rs
nextgen/extension-plugin/src/lib.rs
nextgen/pdk-api/Cargo.toml
nextgen/pdk-api/src/extension.rs
nextgen/pdk-api/src/lib.rs
nextgen/pdk-test-utils/Cargo.toml
nextgen/pdk-test-utils/src/lib.rs
nextgen/pdk-test-utils/src/wrappers.rs
nextgen/pdk/Cargo.toml
nextgen/pdk/src/extension.rs
nextgen/pdk/src/lib.rs
nextgen/plugin/Cargo.toml
packages/cli/CHANGELOG.md
tests/fixtures/migrate/turborepo/app/package.json
tests/fixtures/migrate/turborepo/library/package.json
website/blog/2024-02-07_moon-v1.21.mdx
website/docs/commands/migrate/from-turborepo.mdx
website/docs/guides/extensions.mdx

Copy link

github-actions bot commented Feb 3, 2024

Run report for 2dd05660 (windows-latest, 20)

Total time: 1m 37s | Comparison time: 2m 20s | Estimated savings: 42.6s (30.3% faster)

Action Time Status Info
🟩 SyncWorkspace 180.2ms Passed
🟩 SetupNodeTool(20.11.0) 29.3s Passed
🟩 InstallNodeDeps(20.11.0) 1m 2s Passed
🟩 SyncNodeProject(types) 378.9ms Passed
🟩 SyncNodeProject(runtime) 1.1s Passed
🟦 RunTask(types:build) 1.1s Cached
🟩 SyncNodeProject(website) 712.4ms Passed
🟦 RunTask(runtime:build) 1.1s Cached
🟦 RunTask(website:build) 3.5s Cached
Environment

OS: Windows
Matrix:

os = windows-latest
node-version = 20

Variables:

MOON_NODE_VERSION = 20.11.0
Touched files
Cargo.lock
crates/cli/src/commands/migrate/from_turborepo.rs
crates/cli/src/lib.rs
crates/cli/tests/ext_test.rs
crates/cli/tests/migrate_test.rs
nextgen/config/src/workspace/plugins_config.rs
nextgen/extension-plugin/src/lib.rs
nextgen/pdk-api/Cargo.toml
nextgen/pdk-api/src/extension.rs
nextgen/pdk-api/src/lib.rs
nextgen/pdk-test-utils/Cargo.toml
nextgen/pdk-test-utils/src/lib.rs
nextgen/pdk-test-utils/src/wrappers.rs
nextgen/pdk/Cargo.toml
nextgen/pdk/src/extension.rs
nextgen/pdk/src/lib.rs
nextgen/plugin/Cargo.toml
packages/cli/CHANGELOG.md
tests/fixtures/migrate/turborepo/app/package.json
tests/fixtures/migrate/turborepo/library/package.json
website/blog/2024-02-07_moon-v1.21.mdx
website/docs/commands/migrate/from-turborepo.mdx
website/docs/guides/extensions.mdx

@milesj milesj merged commit 1cd2464 into develop-1.21 Feb 3, 2024
24 checks passed
@milesj milesj deleted the 1.21-turborepo branch February 3, 2024 23:38
milesj added a commit that referenced this pull request Feb 7, 2024
* Remove old code.

* Delete log file.

* chore: Release

* Update docs.

* Add blog post.

* Add tests.

* Update docs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant