Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.24 #1426

Merged
merged 10 commits into from
Apr 18, 2024
Merged

v1.24 #1426

merged 10 commits into from
Apr 18, 2024

Conversation

milesj
Copy link
Collaborator

@milesj milesj commented Apr 10, 2024

No description provided.

milesj and others added 4 commits April 7, 2024 18:20
* Start on command.

* Add more info.

* Update changelog.

* Polish.
* Add new args parsing.

* Add tests.

* Update errors.

* Start on prompts.

* Rework variable gather.

* Fix defaults.

* Fix tests.

* Add theme.

* Fix build.

* Comment out more.
* Update proto.

* Update warpgate.

* Update more deps.

* Update wasm.

* Update schemas.

* Update tests.

* Fixes.

* Disable linux.
Copy link

github-actions bot commented Apr 11, 2024

Run report for 26580f08 (ubuntu-latest, 18)

Total time: 1m 2s | Comparison time: 2m 45s | Estimated savings: 1m 42s (62.0% faster)

Action Time Status Info
🟩 SyncWorkspace 345.3ms Passed
🟩 SetupNodeTool(~18) 19.7s Passed
🟩 InstallNodeDeps(~18) 33.2s Passed
🟩 SyncNodeProject(visualizer) 797.1ms Passed
🟩 SyncNodeProject(types) 800.2ms Passed
🟩 SyncNodeProject(runtime) 199.9ms Passed
🟦 RunTask(visualizer:build) 1.6s Cached
🟩 RunTask(visualizer:format) 3.1s Passed
🟦 RunTask(visualizer:lint) 2.5s Cached
🟦 RunTask(visualizer:test) 1.9s Cached
🟦 RunTask(visualizer:typecheck) 1.6s Cached
🟩 SyncNodeProject(website) 1.6s Passed
🟦 RunTask(types:build) 1.1s Cached
🟦 RunTask(runtime:build) 553.9ms Cached
🟦 RunTask(website:build) 3.5s Cached
Environment

OS: Linux
Matrix:

os = ubuntu-latest
node-version = 18
Touched files
Cargo.lock
Cargo.toml
crates/cli/src/commands/graph/action.rs
crates/cli/tests/run_test.rs
crates/cli/tests/snapshots/run_test__dependencies__changes_primary_hash_if_deps_hash_changes.snap
crates/cli/tests/snapshots/run_test__dependencies__generates_unique_hashes_for_each_target.snap
crates/cli/tests/snapshots/run_test__output_styles__hash.snap
crates/core/action-pipeline/src/actions/run_task.rs
crates/core/test-utils/src/configs.rs
packages/visualizer/src/app.tsx
packages/visualizer/src/components/Graph.tsx
packages/visualizer/src/helpers/render.ts
tests/fixtures/cases/mutex/moon.yml
tests/fixtures/cases/mutex/sleep.mjs
website/blog/2024-04-17_moon-v1.24.mdx
website/blog/img/moon/v1.24.png

Copy link

github-actions bot commented Apr 11, 2024

Run report for 26580f08 (ubuntu-latest, 20)

Total time: 1m 4s | Comparison time: 2m 58s | Estimated savings: 1m 54s (64.1% faster)

Action Time Status Info
🟩 SyncWorkspace 322.7ms Passed
🟩 SetupNodeTool(~20) 20.9s Passed
🟩 InstallNodeDeps(~20) 33s Passed
🟩 SyncNodeProject(visualizer) 688.1ms Passed
🟩 SyncNodeProject(types) 688.1ms Passed
🟩 SyncNodeProject(runtime) 216.1ms Passed
🟦 RunTask(visualizer:build) 1.8s Cached
🟩 RunTask(visualizer:format) 3.5s Passed
🟦 RunTask(visualizer:lint) 3s Cached
🟦 RunTask(visualizer:test) 2.3s Cached
🟦 RunTask(visualizer:typecheck) 1.3s Cached
🟩 SyncNodeProject(website) 1.7s Passed
🟦 RunTask(types:build) 1.7s Cached
🟦 RunTask(runtime:build) 651.2ms Cached
🟦 RunTask(website:build) 3.7s Cached
Environment

OS: Linux
Matrix:

os = ubuntu-latest
node-version = 20
Touched files
Cargo.lock
Cargo.toml
crates/cli/src/commands/graph/action.rs
crates/cli/tests/run_test.rs
crates/cli/tests/snapshots/run_test__dependencies__changes_primary_hash_if_deps_hash_changes.snap
crates/cli/tests/snapshots/run_test__dependencies__generates_unique_hashes_for_each_target.snap
crates/cli/tests/snapshots/run_test__output_styles__hash.snap
crates/core/action-pipeline/src/actions/run_task.rs
crates/core/test-utils/src/configs.rs
packages/visualizer/src/app.tsx
packages/visualizer/src/components/Graph.tsx
packages/visualizer/src/helpers/render.ts
tests/fixtures/cases/mutex/moon.yml
tests/fixtures/cases/mutex/sleep.mjs
website/blog/2024-04-17_moon-v1.24.mdx
website/blog/img/moon/v1.24.png

Copy link

github-actions bot commented Apr 11, 2024

Run report for 94490db0 (windows-latest, 20)

Total time: 2m 16s | Comparison time: 12m 42s | Estimated savings: 10m 26s (82.2% faster)

Action Time Status Info
🟩 SyncWorkspace 202ms Passed
🟩 SetupNodeTool(~20) 26.5s Passed
🟩 InstallNodeDeps(~20) 1m 5s Passed
🟩 SyncNodeProject(types) 708.3ms Passed
🟩 SyncNodeProject(visualizer) 708.3ms Passed
🟩 SyncNodeProject(runtime) 1s Passed
🟦 RunTask(types:build) 1.6s Cached
🟩 SyncNodeProject(nx-compat) 1.7s Passed
🟩 SyncNodeProject(report) 1.6s Passed
🟩 SyncNodeProject(website) 928.6ms Passed
🟦 RunTask(runtime:build) 1.3s Cached
🟩 RunTask(runtime:format) 2.9s Passed
🟦 RunTask(nx-compat:build) 2s Cached
🟦 RunTask(website:build) 12.6s Cached
🟩 RunTask(website:format) 22s Passed
🟦 RunTask(website:lint) 13.3s Cached
🟦 RunTask(website:test) 13.7s Cached
🟦 RunTask(website:typecheck) 1.1s Cached
🟩 RunTask(nx-compat:format) 3.3s Passed
🟦 RunTask(nx-compat:lint) 1.8s Cached
And 19 more...
Expanded report
Action Time Status Info
🟦 RunTask(nx-compat:test) 2.2s Cached
🟦 RunTask(nx-compat:typecheck) 1s Cached
🟦 RunTask(runtime:lint) 1.4s Cached
🟦 RunTask(runtime:test) 2.3s Cached
🟦 RunTask(runtime:typecheck) 1.7s Cached
🟦 RunTask(report:build) 1.5s Cached
🟩 RunTask(report:format) 3.6s Passed
🟦 RunTask(report:lint) 2.1s Cached
🟦 RunTask(report:test) 2.5s Cached
🟦 RunTask(report:typecheck) 1.1s Cached
🟩 RunTask(types:format) 3.6s Passed
🟦 RunTask(types:lint) 1.9s Cached
🟦 RunTask(types:test) 2.4s Cached
🟦 RunTask(types:typecheck) 1.2s Cached
🟦 RunTask(visualizer:build) 1.9s Cached
🟩 RunTask(visualizer:format) 3.6s Passed
🟦 RunTask(visualizer:lint) 2.5s Cached
🟦 RunTask(visualizer:test) 1.1s Cached
🟦 RunTask(visualizer:typecheck) 727.5ms Cached
Environment

OS: Windows
Matrix:

os = windows-latest
node-version = 20
Touched files
.github/workflows/rust.yml
.yarn/versions/8c7c3e4a.yml
Cargo.lock
Cargo.toml
crates/cli/src/app.rs
crates/cli/src/commands/ci.rs
crates/cli/src/commands/clean.rs
crates/cli/src/commands/generate.rs
crates/cli/src/commands/graph/action.rs
crates/cli/src/commands/graph/project.rs
crates/cli/src/commands/mod.rs
crates/cli/src/commands/query.rs
crates/cli/src/commands/templates.rs
crates/cli/src/lib.rs
crates/cli/src/queries/projects.rs
crates/cli/tests/generate_test.rs
crates/cli/tests/project_graph_test.rs
crates/cli/tests/query_test.rs
crates/cli/tests/run_bun_test.rs
crates/cli/tests/run_test.rs
crates/cli/tests/snapshots/generate_test__errors_when_parsing_custom_var_types.snap
crates/cli/tests/snapshots/project_graph_test__single_project_with_dependents.snap
crates/cli/tests/snapshots/query_test__tasks__returns_all_by_default.snap
crates/cli/tests/snapshots/run_bun_test__bun__runs_self.snap
crates/cli/tests/snapshots/run_test__dependencies__changes_primary_hash_if_deps_hash_changes.snap
crates/cli/tests/snapshots/run_test__dependencies__generates_unique_hashes_for_each_target.snap
crates/cli/tests/snapshots/run_test__output_styles__hash.snap
crates/core/action-context/Cargo.toml
crates/core/action-context/src/lib.rs
crates/core/action-pipeline/src/actions/run_task.rs
crates/core/action-pipeline/src/subscribers/local_cache.rs
crates/core/logger/Cargo.toml
crates/core/platform/src/manager.rs
crates/core/test-utils/Cargo.toml
crates/core/test-utils/src/configs.rs
nextgen/action-graph/src/action_graph_builder.rs
nextgen/action-graph/tests/action_graph_test.rs
nextgen/cache/src/cache_engine.rs
nextgen/codegen/Cargo.toml
nextgen/codegen/src/codegen_error.rs
nextgen/codegen/src/generate_command.rs
nextgen/codegen/src/lib.rs
nextgen/codegen/src/templates_command.rs
nextgen/codegen/tests/generate_test.rs
nextgen/common/src/consts.rs
nextgen/config/src/project/task_options_config.rs
nextgen/config/src/template_config.rs
nextgen/config/src/workspace/runner_config.rs
nextgen/config/tests/template_config_test.rs
nextgen/config/tests/toolchain_config_test.rs
nextgen/console/Cargo.toml
nextgen/console/src/console.rs
nextgen/console/src/lib.rs
nextgen/console/src/prompts.rs
nextgen/process/src/command_inspector.rs
nextgen/project-graph/src/project_graph.rs
nextgen/query/Cargo.toml
nextgen/task-builder/src/tasks_builder.rs
nextgen/task-builder/tests/__fixtures__/builder/moon.yml
nextgen/task-builder/tests/tasks_builder_test.rs
nextgen/task/src/task.rs
nextgen/task/src/task_options.rs
nextgen/workspace/src/workspace.rs
packages/cli/CHANGELOG.md
packages/types/src/project-config.ts
packages/types/src/project.ts
packages/types/src/tasks-config.ts
packages/types/src/workspace-config.ts
packages/visualizer/package.json
packages/visualizer/src/app.tsx
packages/visualizer/src/components/Graph.tsx
packages/visualizer/src/helpers/render.ts
rust-toolchain.toml
tests/fixtures/cases/mutex/moon.yml
tests/fixtures/cases/mutex/sleep.mjs
wasm/test-plugin/Cargo.lock
website/blog/2024-04-17_moon-v1.24.mdx
website/blog/img/moon/v1.24.png
website/docs/commands/action-graph.mdx
website/docs/commands/ci.mdx
website/docs/commands/project-graph.mdx
website/docs/commands/query/projects.mdx
website/docs/commands/templates.mdx
website/docs/config/project.mdx
website/docs/config/workspace.mdx
website/docs/guides/ci.mdx
website/docs/guides/root-project.mdx
website/sidebars.ts
website/static/schemas/project.json
website/static/schemas/tasks.json
website/static/schemas/workspace.json
website/tsconfig.json
yarn.lock

Copy link

github-actions bot commented Apr 11, 2024

Run report for 94490db0 (windows-latest, 18)

Total time: 2m 27s | Comparison time: 13m 37s | Estimated savings: 11m 9s (81.9% faster)

Action Time Status Info
🟩 SyncWorkspace 138.9ms Passed
🟩 SetupNodeTool(~18) 31.2s Passed
🟩 InstallNodeDeps(~18) 1m 9s Passed
🟩 SyncNodeProject(types) 425.9ms Passed
🟩 SyncNodeProject(visualizer) 428.4ms Passed
🟩 SyncNodeProject(runtime) 679.1ms Passed
🟦 RunTask(types:build) 1.5s Cached
🟩 SyncNodeProject(nx-compat) 1.5s Passed
🟩 SyncNodeProject(report) 1.5s Passed
🟩 SyncNodeProject(website) 569.7ms Passed
🟦 RunTask(runtime:build) 1.2s Cached
🟦 RunTask(nx-compat:build) 1.9s Cached
🟩 RunTask(nx-compat:format) 3.3s Passed
🟦 RunTask(website:build) 11.4s Cached
🟩 RunTask(website:format) 21.8s Passed
🟦 RunTask(website:lint) 12.2s Cached
🟦 RunTask(website:test) 12.8s Cached
🟦 RunTask(website:typecheck) 1.2s Cached
🟦 RunTask(nx-compat:lint) 1.8s Cached
🟦 RunTask(nx-compat:test) 2.9s Cached
And 19 more...
Expanded report
Action Time Status Info
🟦 RunTask(nx-compat:typecheck) 2.3s Cached
🟩 RunTask(runtime:format) 1.7s Passed
🟦 RunTask(runtime:lint) 2.3s Cached
🟦 RunTask(runtime:test) 3.4s Cached
🟦 RunTask(runtime:typecheck) 2.9s Cached
🟦 RunTask(report:build) 1.2s Cached
🟩 RunTask(report:format) 3.7s Passed
🟦 RunTask(report:lint) 2.6s Cached
🟦 RunTask(report:test) 2s Cached
🟦 RunTask(report:typecheck) 2.1s Cached
🟩 RunTask(types:format) 4.7s Passed
🟦 RunTask(types:lint) 2.9s Cached
🟦 RunTask(types:test) 3.5s Cached
🟦 RunTask(types:typecheck) 1.1s Cached
🟦 RunTask(visualizer:build) 2.1s Cached
🟩 RunTask(visualizer:format) 4.1s Passed
🟦 RunTask(visualizer:lint) 2.8s Cached
🟦 RunTask(visualizer:test) 1.4s Cached
🟦 RunTask(visualizer:typecheck) 843.6ms Cached
Environment

OS: Windows
Matrix:

os = windows-latest
node-version = 18
Touched files
.github/workflows/rust.yml
.yarn/versions/8c7c3e4a.yml
Cargo.lock
Cargo.toml
crates/cli/src/app.rs
crates/cli/src/commands/ci.rs
crates/cli/src/commands/clean.rs
crates/cli/src/commands/generate.rs
crates/cli/src/commands/graph/action.rs
crates/cli/src/commands/graph/project.rs
crates/cli/src/commands/mod.rs
crates/cli/src/commands/query.rs
crates/cli/src/commands/templates.rs
crates/cli/src/lib.rs
crates/cli/src/queries/projects.rs
crates/cli/tests/generate_test.rs
crates/cli/tests/project_graph_test.rs
crates/cli/tests/query_test.rs
crates/cli/tests/run_bun_test.rs
crates/cli/tests/run_test.rs
crates/cli/tests/snapshots/generate_test__errors_when_parsing_custom_var_types.snap
crates/cli/tests/snapshots/project_graph_test__single_project_with_dependents.snap
crates/cli/tests/snapshots/query_test__tasks__returns_all_by_default.snap
crates/cli/tests/snapshots/run_bun_test__bun__runs_self.snap
crates/cli/tests/snapshots/run_test__dependencies__changes_primary_hash_if_deps_hash_changes.snap
crates/cli/tests/snapshots/run_test__dependencies__generates_unique_hashes_for_each_target.snap
crates/cli/tests/snapshots/run_test__output_styles__hash.snap
crates/core/action-context/Cargo.toml
crates/core/action-context/src/lib.rs
crates/core/action-pipeline/src/actions/run_task.rs
crates/core/action-pipeline/src/subscribers/local_cache.rs
crates/core/logger/Cargo.toml
crates/core/platform/src/manager.rs
crates/core/test-utils/Cargo.toml
crates/core/test-utils/src/configs.rs
nextgen/action-graph/src/action_graph_builder.rs
nextgen/action-graph/tests/action_graph_test.rs
nextgen/cache/src/cache_engine.rs
nextgen/codegen/Cargo.toml
nextgen/codegen/src/codegen_error.rs
nextgen/codegen/src/generate_command.rs
nextgen/codegen/src/lib.rs
nextgen/codegen/src/templates_command.rs
nextgen/codegen/tests/generate_test.rs
nextgen/common/src/consts.rs
nextgen/config/src/project/task_options_config.rs
nextgen/config/src/template_config.rs
nextgen/config/src/workspace/runner_config.rs
nextgen/config/tests/template_config_test.rs
nextgen/config/tests/toolchain_config_test.rs
nextgen/console/Cargo.toml
nextgen/console/src/console.rs
nextgen/console/src/lib.rs
nextgen/console/src/prompts.rs
nextgen/process/src/command_inspector.rs
nextgen/project-graph/src/project_graph.rs
nextgen/query/Cargo.toml
nextgen/task-builder/src/tasks_builder.rs
nextgen/task-builder/tests/__fixtures__/builder/moon.yml
nextgen/task-builder/tests/tasks_builder_test.rs
nextgen/task/src/task.rs
nextgen/task/src/task_options.rs
nextgen/workspace/src/workspace.rs
packages/cli/CHANGELOG.md
packages/types/src/project-config.ts
packages/types/src/project.ts
packages/types/src/tasks-config.ts
packages/types/src/workspace-config.ts
packages/visualizer/package.json
packages/visualizer/src/app.tsx
packages/visualizer/src/components/Graph.tsx
packages/visualizer/src/helpers/render.ts
rust-toolchain.toml
tests/fixtures/cases/mutex/moon.yml
tests/fixtures/cases/mutex/sleep.mjs
wasm/test-plugin/Cargo.lock
website/blog/2024-04-17_moon-v1.24.mdx
website/blog/img/moon/v1.24.png
website/docs/commands/action-graph.mdx
website/docs/commands/ci.mdx
website/docs/commands/project-graph.mdx
website/docs/commands/query/projects.mdx
website/docs/commands/templates.mdx
website/docs/config/project.mdx
website/docs/config/workspace.mdx
website/docs/guides/ci.mdx
website/docs/guides/root-project.mdx
website/sidebars.ts
website/static/schemas/project.json
website/static/schemas/tasks.json
website/static/schemas/workspace.json
website/tsconfig.json
yarn.lock

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Attention: Patch coverage is 64.07767% with 222 lines in your changes are missing coverage. Please review.

Project coverage is 78.82%. Comparing base (6185027) to head (94490db).
Report is 13 commits behind head on master.

Files Patch % Lines
nextgen/codegen/src/generate_command.rs 71.88% 70 Missing ⚠️
nextgen/console/src/prompts.rs 20.58% 54 Missing ⚠️
nextgen/codegen/src/templates_command.rs 0.00% 46 Missing ⚠️
crates/cli/src/commands/ci.rs 0.00% 18 Missing ⚠️
nextgen/process/src/command_inspector.rs 60.86% 9 Missing ⚠️
nextgen/config/src/template_config.rs 68.75% 5 Missing ⚠️
...rates/core/action-pipeline/src/actions/run_task.rs 84.61% 4 Missing ⚠️
nextgen/action-graph/src/action_graph_builder.rs 86.20% 4 Missing ⚠️
nextgen/cache/src/cache_engine.rs 80.00% 3 Missing ⚠️
nextgen/console/src/console.rs 70.00% 3 Missing ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1426      +/-   ##
==========================================
- Coverage   79.21%   78.82%   -0.39%     
==========================================
  Files         268      272       +4     
  Lines       22485    22834     +349     
==========================================
+ Hits        17811    17999     +188     
- Misses       4674     4835     +161     
Flag Coverage Δ
rust 78.82% <64.07%> (-0.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

milesj and others added 6 commits April 11, 2024 15:37
* Add check to ci.

* Add blog post.
* Fix clean.

* Update bun install.

* Update proto.

* Update root level task.

* Fix workspace detection.
* Polish.

* Add dependents.

* Update changelog.

* Add to query.

* Add test.

* Bump viz.

* Update command docs.

* Update blog post.
* feat: add mutex option to task configuration

Signed-off-by: Andres Correa Casablanca <[email protected]>

* docs: add mutex section to task.options docs

Signed-off-by: Andres Correa Casablanca <[email protected]>

* refactor: remove useless impls

Signed-off-by: Andres Correa Casablanca <[email protected]>

* refactor: use dashmap

Signed-off-by: Andres Correa Casablanca <[email protected]>

* perf: remove allocation

Signed-off-by: Andres Correa Casablanca <[email protected]>

* refactor: fix code style issues

Signed-off-by: Andres Correa Casablanca <[email protected]>

---------

Signed-off-by: Andres Correa Casablanca <[email protected]>
* Add setting.

* Update docs.

* Fix lint.
* Update deps.

* Update layout.

* Finalize blog post.

* Fix tests.

* Use millis.
@milesj milesj marked this pull request as ready for review April 18, 2024 00:20
@milesj milesj merged commit 26580f0 into master Apr 18, 2024
41 of 43 checks passed
@milesj milesj deleted the develop-1.24 branch April 18, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants