Added big connect wallet buttons if the user's wallet is not connected #269
Conversation
codenamejason
added
2-17
enhancement
codenamejason
removed
enhancement
|
Okay, I think this is okay to be merged. I know that the full-screen "wallet not connected" modal might be a better idea, but this implementation is currently bug-free, and it makes it very clear to the user that they need to connect their wallet. We should test this feature out in user testing to see if users prefer this over a full-screen modal. |
|
Testing this and the issue with the small message at the top is that someone could be a host and scroll down then miss it. Especially with the upcoming changes with the Join Room / Create Room Buttons. That is why it would be better to have the large modal to let the user know like it was discussed in the product meeting. |
|
Okay, the connect wallet button now sticks to the top. But I think we could test this feature out to see how users like it compared to a full modal. Personally, I hate when web3 apps make me connect my wallet before being able to see their app, I feel many others may share the same opinion as well. |
The result from the product meeting was one we as a team agreed on and you are now pushing your own decisions. Please implement the one requested at the meeting |
|
K will make a new PR |
No description provided.