Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added button + function for removing non-ens addresses #381

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

varunv5000
Copy link
Collaborator

No description provided.

@vercel
Copy link

vercel bot commented Apr 7, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/moonshotoooor/tip-party/EcrhqA1Uttvz9zz9LA55Y5T1oLzF
✅ Preview: https://tip-party-git-filter-non-ens-moonshotoooor.vercel.app

@varunv5000
Copy link
Collaborator Author

The function is still a bit slow, would filtering the ens names through the backend make this considerably faster?

@farque65
Copy link
Contributor

farque65 commented Apr 7, 2022

The function is still a bit slow, would filtering the ens names through the backend make this considerably faster?

Have you tried running this against 40 or more signed in guests?

To improve the speed the optimal way would be to have an api that resolves an array of addresses.

  • This would require making a seperate api folder because the current backend directory contains firebase functions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants