Refactore FamixTComment #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not is #content property but go throught source anchors instead.
|
Does it require an update of VerveineJ? We do use the comment relation at BL and i'd like to know if this can become a problematic change in our case when importing model (not sure it uses deprecated setter) |
|
Does not appear to be used in VVJ |
|
Indeed! VVJ already uses indexed file anchors :) IIRC, Fame is upsetting things directly in variables but if they are missing there is a fallback to use the setters, and if there is not it logs missing properties in the transcript. (I'm not 100% sure tho) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not is #content property but go through source anchors instead.