Clean code + fix bug (#isSelf was sent to another kind of node)

moosetechnology · Dec 11, 2024 · 0318ae2 · 0318ae2
1 parent 019f471
commit 0318ae2
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 13 deletions.
diff --git a/src/Famix-Python-Importer/FamixPythonImporterVisitor.class.st b/src/Famix-Python-Importer/FamixPythonImporterVisitor.class.st
@@ -829,7 +829,6 @@ FamixPythonImporterVisitor >> visitInternalInstanceVariableAccess: anInternalIns
 	self
 		resolve: ((SRIdentifierWithNode identifier: anInternalInstanceVariableAccess name)
 				 expectedKind: { FamixPythonAttribute };
-				 notFoundReplacementEntity: [ :unresolved :currentEntity | self flag: #todo. 1 halt "self ensureStubUnknownAccessedOrReferencedEntityNamed: unresolved identifier" ];
 				 yourself)
 		foundAction: [ :entity :currentEntity |
 			| association |

diff --git a/src/Famix-Python-Importer/PyFieldAccessExpressionNode.extension.st b/src/Famix-Python-Importer/PyFieldAccessExpressionNode.extension.st
@@ -16,12 +16,6 @@ PyFieldAccessExpressionNode >> isInternalInstanceVariableAccess [
 	^ self receiver isSelf
 ]
 
-{ #category : '*Famix-Python-Importer' }
-PyFieldAccessExpressionNode >> isSelf [
-
-	^ false
-]
-
 { #category : '*Famix-Python-Importer' }
 PyFieldAccessExpressionNode >> name [
 	^ self nameToken value

diff --git a/src/Famix-Python-Importer/PyFunctionCallExpressionNode.extension.st b/src/Famix-Python-Importer/PyFunctionCallExpressionNode.extension.st
@@ -5,9 +5,3 @@ PyFunctionCallExpressionNode >> isFunctionCallExpression [
 
 	^ true
 ]
-
-{ #category : '*Famix-Python-Importer' }
-PyFunctionCallExpressionNode >> isSelf [
-
-	^ false
-]
diff --git a/src/Famix-Python-Importer/PyRootNode.extension.st b/src/Famix-Python-Importer/PyRootNode.extension.st
@@ -53,6 +53,12 @@ PyRootNode >> isLeftSideOfAssignation: aNode [
 	^ false
 ]
 
+{ #category : '*Famix-Python-Importer' }
+PyRootNode >> isSelf [
+
+	^ false
+]
+
 { #category : '*Famix-Python-Importer' }
 PyRootNode >> isSubscriptExpression [
-Original file line number
+Diff line change
@@ Expand Up / @@ -5,9 +5,3 @@ PyFunctionCallExpressionNode >> isFunctionCallExpression [ @@
     	^ true
     ]
-    { #category : '*Famix-Python-Importer' }
-    PyFunctionCallExpressionNode >> isSelf [
-    	^ false
-    ]