Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport playlist refresh #385

Merged
merged 6 commits into from
Apr 12, 2024
Merged

Backport playlist refresh #385

merged 6 commits into from
Apr 12, 2024
+275 −123

Commits on Apr 12, 2024

  1. Improve startup performance by deferring playlist loading 

    This change prevents loading of Spotify playlists from blocking other
common Mopidy operations. These include startup and browsing, as well as
refreshing of playlists in general. Loading Spotify playlists will
always happen in a dedicated thread, and only one refresh thread will
run at a time.

The playlists_loaded event is manually re-dispatched when Spotify is
done loading playlists, as a signal that clients should refresh their
list of playlists. This is necessary, as otherwise clients relying
solely on websocket notifications may never discover the newly-loaded
playlists.
    @djmattyg007 @kingosticks
    djmattyg007 authored and kingosticks committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    358e76c View commit details
    Browse the repository at this point in the history

  2. web: thread-safe locks for cache and refresh token

    @kingosticks
    3np authored and kingosticks committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    aeeb0e9 View commit details
    Browse the repository at this point in the history

  3. use lock context manager

    @kingosticks
    kingosticks committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    e2fea50 View commit details
    Browse the repository at this point in the history

  4. Get playlist names in foreground, tracks in background

    @kingosticks
    kingosticks committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    6ae154d View commit details
    Browse the repository at this point in the history

  5. pip install Mopidy-Spotify==5.0.0a1 

    This is the minimum version release using gst-plugins-spotify (i.e. that works)
    @kingosticks
    kingosticks committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    aab63f0 View commit details
    Browse the repository at this point in the history

  6. Remove old test that makes no sense

    @kingosticks
    kingosticks committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    4ed6a24 View commit details
    Browse the repository at this point in the history