Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented server keep alive setting and usage in connect #883

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

andsel
Copy link
Collaborator

@andsel andsel commented Dec 18, 2024

Release notes

Added configuration setting so that the broker can specify a keep alive other then the one selected by clients.

What does this PR do?

Updates the configuration harness to expose a duration setting name server_keep_alive.
Updated the connAck properties creation to include server keep alive if the broker configuration has selected it.
Updates the connect processing to leverage the server keep alive selected keep alive instead of the client one.

Why is it important/What is the impact to the user?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the Changelog if it's a feature or a fix that has to be reported

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

@andsel andsel added the mqtt5 label Dec 18, 2024
@andsel andsel self-assigned this Dec 18, 2024
@andsel andsel force-pushed the feature/server_keep_alive branch from 63c7e5b to 8fc6c5d Compare December 18, 2024 16:20
@andsel andsel merged commit c9b4740 into moquette-io:main Dec 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server can define its own Keep Alive in CONNACK
1 participant