-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce SkipLastWhile
extension
#1085
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1085 +/- ##
==========================================
+ Coverage 93.22% 93.30% +0.07%
==========================================
Files 112 113 +1
Lines 3410 3448 +38
Branches 962 971 +9
==========================================
+ Hits 3179 3217 +38
Misses 215 215
Partials 16 16 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a really good quality PR. Thanks for picking up #1085 and taking the trouble to conform to the project's conventions.
I've left a few comments & suggestion from my initial review.
Added missing period and added tags around "null" in docstrings Co-authored-by: Atif Aziz <[email protected]>
…sequence to an array
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sharing your findings.
I have done a second review pass and submitted some suggestions and comments.
I reckon we need one final pass and then we can get this in! 🏁
PS Run build.cmd
or build.sh
locally to update the generated extensions since the CI checks/runs are failing due to stale code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the comments I've left, this needs merging with the base since .NET 9 has been added as a new target and the public API will need entries for this new extension. After that, I think we're good to merge. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your patience, all the follow-up and contributing this in the first place.
Adds
SkipLastWhile
extension method and associated testsCloses #1036