Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce SkipLastWhile extension #1085

Merged
merged 16 commits into from
Dec 30, 2024

Conversation

ArmoryNode
Copy link
Contributor

@ArmoryNode ArmoryNode commented Oct 22, 2024

Adds SkipLastWhile extension method and associated tests

Closes #1036

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.30%. Comparing base (72c3c66) to head (8a6ac3d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1085      +/-   ##
==========================================
+ Coverage   93.22%   93.30%   +0.07%     
==========================================
  Files         112      113       +1     
  Lines        3410     3448      +38     
  Branches      962      971       +9     
==========================================
+ Hits         3179     3217      +38     
  Misses        215      215              
  Partials       16       16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@atifaziz atifaziz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really good quality PR. Thanks for picking up #1085 and taking the trouble to conform to the project's conventions.

I've left a few comments & suggestion from my initial review.

MoreLinq.Test/SkipLastWhileTest.cs Outdated Show resolved Hide resolved
MoreLinq.Test/SkipLastWhileTest.cs Outdated Show resolved Hide resolved
MoreLinq.Test/SkipLastWhileTest.cs Outdated Show resolved Hide resolved
MoreLinq.Test/SkipLastWhileTest.cs Outdated Show resolved Hide resolved
MoreLinq.Test/SkipLastWhileTest.cs Outdated Show resolved Hide resolved
MoreLinq.Test/SkipLastWhileTest.cs Outdated Show resolved Hide resolved
MoreLinq.Test/SkipLastWhileTest.cs Outdated Show resolved Hide resolved
MoreLinq/SkipLastWhile.cs Outdated Show resolved Hide resolved
MoreLinq/SkipLastWhile.cs Outdated Show resolved Hide resolved
MoreLinq/SkipLastWhile.cs Outdated Show resolved Hide resolved
@ArmoryNode ArmoryNode requested a review from atifaziz October 30, 2024 17:59
Copy link
Member

@atifaziz atifaziz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sharing your findings.

I have done a second review pass and submitted some suggestions and comments.

I reckon we need one final pass and then we can get this in! 🏁


PS Run build.cmd or build.sh locally to update the generated extensions since the CI checks/runs are failing due to stale code.

MoreLinq/SkipLastWhile.cs Show resolved Hide resolved
MoreLinq/SkipLastWhile.cs Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
MoreLinq.Test/SkipLastWhileTest.cs Outdated Show resolved Hide resolved
MoreLinq.Test/SkipLastWhileTest.cs Show resolved Hide resolved
MoreLinq.Test/SkipLastWhileTest.cs Show resolved Hide resolved
Copy link
Member

@atifaziz atifaziz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the comments I've left, this needs merging with the base since .NET 9 has been added as a new target and the public API will need entries for this new extension. After that, I think we're good to merge. Thanks!

MoreLinq/SkipLastWhile.cs Outdated Show resolved Hide resolved
MoreLinq.Test/SkipLastWhileTest.cs Show resolved Hide resolved
MoreLinq.Test/SkipLastWhileTest.cs Outdated Show resolved Hide resolved
MoreLinq.Test/SkipLastWhileTest.cs Outdated Show resolved Hide resolved
MoreLinq.Test/SkipLastWhileTest.cs Outdated Show resolved Hide resolved
MoreLinq.Test/SkipLastWhileTest.cs Outdated Show resolved Hide resolved
MoreLinq.Test/SkipLastWhileTest.cs Outdated Show resolved Hide resolved
Copy link
Member

@atifaziz atifaziz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience, all the follow-up and contributing this in the first place.

@atifaziz atifaziz merged commit cf2b725 into morelinq:master Dec 30, 2024
4 checks passed
@ArmoryNode ArmoryNode deleted the add-skiplastwhile branch December 30, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove tail items while condition is true
3 participants