Bugfix - which_ids in util.classification for templates

morganjwilliams · Nov 1, 2024 · a7be1ff · a7be1ff
1 parent 287e161
commit a7be1ff
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/pyrolite/util/classification.py b/pyrolite/util/classification.py
@@ -195,7 +195,7 @@ def _add_polygons_to_axes(
         axes_scale=100.0,
         add_labels=False,
         which_labels="ID",
-        which_ids=[],
+        which_ids=None,
         **kwargs,
     ):
         """
@@ -247,7 +247,7 @@ def _add_polygons_to_axes(
 
         use_keys = not which_labels.lower().startswith("name")
 
-        if not which_ids:
+        if which_ids is None:
             which_ids = list(self.fields.keys())
 
         for k, cfg in self.fields.items():
@@ -412,7 +412,7 @@ def add_to_axes(
         axes_scale=100.0,
         add_labels=False,
         which_labels="ID",
-        which_ids=[],
+        which_ids=None,
         label_at_centroid=True,
         **kwargs,
     ):
@@ -472,7 +472,7 @@ def add_to_axes(
             if not np.isclose(self.default_scale, axes_scale):
                 rescale_by = axes_scale / self.default_scale
 
-        if not which_ids:
+        if which_ids is None:
             which_ids = list(self.fields.keys())
 
         if add_labels: