Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java Rest Template Changes #11

Merged
merged 9 commits into from
Jan 16, 2025
Merged

Java Rest Template Changes #11

merged 9 commits into from
Jan 16, 2025

Conversation

harveymmaunders
Copy link
Contributor

@harveymmaunders harveymmaunders commented Jan 10, 2025 •
edited
Loading

Updated README

  • Explain how to use the template
  • How to call API with okHttp or retrofit
  • Changes that need to be made for each method

Second method to call API

  • Simpler way to call an API
  • Only need to change API endpoint on ExampleApplication.java
  • Recommended to use to test connection to API (as easier to configure and call than the MsRetrofitWrapper)
  • All steps shown in a single method in ExampleApplication

ApiUrl

  • Switched from from API to just the MS API domain, so only need to change the endpoint, rather than url and endpoints
  • Moved it to microprofile config. Can do seperate configs for UAT and prod (as two different domains), whereas previously hardcoded into the app

Other

  • Log when bearer token is retrieved
  • Minor test syntax changes
  • Upgraded gradle from 8.3 to 8.10

@harveymmaunders harveymmaunders requested a review from a team as a code owner January 10, 2025 13:22
harveymmaunders added a commit that referenced this pull request Jan 16, 2025
@harveymmaunders
Merge pull request #11 from harveymmaunders/java-websocket-template
734a657 
Gradle dependency format
@harveymmaunders harveymmaunders merged commit e75b3a6 into morganstanley:main Jan 16, 2025
12 checks passed
@harveymmaunders harveymmaunders deleted the java-rest-template branch January 16, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willosborne willosborne willosborne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harveymmaunders @willosborne