Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default assertion pane message #1040

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

M6AI
Copy link
Contributor

@M6AI M6AI commented Jan 1, 2024

Bug / Requirement Description

Assertion pane displays "Please select an entry." whenever there is nothing to display which is wrong in the case there are still children entries.

Solution description

In case there are no child entry of the selected entry, the default message will make a note of this very fact.

Checklist:

  • Test
  • Example (both test_plan.py and .rst)
  • Documentation (API)
  • News fragment present for release notes
  • MS info leakage check
  • For new driver: driver index page
  • For new assertion: ui/pdf/std renderers, documentation
  • For new cmdline arg: documentation

@M6AI M6AI requested a review from Pyifan as a code owner January 1, 2024 12:35
@M6AI M6AI merged commit 430e6e2 into morganstanley:main Jan 3, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants