Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure stop of drivers upon a startup exceptions #1042

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

M6AI
Copy link
Contributor

@M6AI M6AI commented Jan 5, 2024

Bug / Requirement Description

The following scenario leaves the drivers in wrong status. Start up an environment with three drivers, first successful, second fails with exception, third is skipped. In interactive mode, the control allows another startup attempt whereas the failed driver appears starting and it is now reports success for the overall startup even though that driver is stuck in starting status.

Solution description

Enforce proper shutdown upon an exception in interactive mode.

Checklist:

  • Test
  • Example (both test_plan.py and .rst)
  • Documentation (API)
  • News fragment present for release notes
  • MS info leakage check
  • For new driver: driver index page
  • For new assertion: ui/pdf/std renderers, documentation
  • For new cmdline arg: documentation

@M6AI M6AI requested a review from Pyifan as a code owner January 5, 2024 09:47
@M6AI M6AI merged commit 8981038 into morganstanley:main Jan 9, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants