Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix releaseherald documentation #1180

Merged
merged 3 commits into from
Feb 6, 2025
Merged

Fix releaseherald documentation #1180

merged 3 commits into from
Feb 6, 2025

Conversation

zsambokiandras
Copy link
Contributor

@zsambokiandras zsambokiandras commented Feb 6, 2025 •
edited
Loading

Bug / Requirement Description

Documentation not rendering correctly with new version of mkdocs.

Solution description

Minor documentation changes in md files and Python docstrings.

Checklist:

  • Test
  • Example (both test_plan.py and .rst)
  • Documentation (API)
  • News fragment present for release notes
  • MS info leakage check
  • For new driver: driver index page
  • For new assertion: ui/pdf/std renderers, documentation
  • For new cmdline arg: documentation

@zsambokiandras zsambokiandras marked this pull request as ready for review February 6, 2025 12:18
@zsambokiandras zsambokiandras requested a review from a team as a code owner February 6, 2025 12:18
rnemes
rnemes approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@rnemes rnemes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rnemes rnemes merged commit 84c0fd0 into morganstanley:main Feb 6, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnemes rnemes rnemes approved these changes

@Pyifan Pyifan Pyifan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zsambokiandras @rnemes @Pyifan