Update last total assets in updateWithdrawQueue #337
Conversation
|
Comments on morpho-org/metamorpho-v1.1#2 to address |
MerlinEgalite
requested review from
a team,
adhusson,
QGarchery and
MathisGD
and removed request for
a team
Co-authored-by: Romain Milon <[email protected]> Signed-off-by: Jean-Grimal <[email protected]>
Co-authored-by: Romain Milon <[email protected]> Signed-off-by: Jean-Grimal <[email protected]>
Co-authored-by: Merlin Egalite <[email protected]> Signed-off-by: Jean-Grimal <[email protected]>
There was a problem hiding this comment.
The forced removed market removal reducing the fee is not an issue to me: the fee is called a performance fee, and having to remove a market is part of the risk of the vault managers. It's up to vault managers to decide if they want to accrue interest right after removing a market, to start accruing fees again
| @@ -360,6 +370,9 @@ contract MetaMorpho is ERC4626, ERC20Permit, Ownable2Step, Multicall, IMetaMorph | |||
|
|
|||
| withdrawQueue = newWithdrawQueue; | |||
|
|
|||
| // Accrue interest on all the enabled markets except the removed ones. | |||
There was a problem hiding this comment.
Wait this does not accrue interest ?
There was a problem hiding this comment.
| // Accrue interest on all the enabled markets except the removed ones. | |
| // Accrue fee on all the enabled markets except the removed ones. |
Interesting take. Out of curiosity, how would you recommend to do so? |
Yes, or deposit 1 atomic asset on behalf of a dummy address |
|
Replaced with #359 |
Fixes https://cantina.xyz/ai/8409a0ce-6c21-4cc9-8ef2-bd77ce7425af/findings/5a81700d-ff95-422a-be37-e24f7e4d50a9