Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix order of arguments to loss #3754

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Fix order of arguments to loss #3754

merged 2 commits into from
Jan 31, 2025

Conversation

gsganden
Copy link
Contributor

@gsganden gsganden commented Jan 28, 2025 •
edited
Loading

What does this PR do?

Fixes loss(batch, outputs) to loss(outputs, batch) at one point in docs/source/trainer/using_the_trainer.rst.

What issue(s) does this change relate to?

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

dakinggg
dakinggg approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dakinggg
Copy link
Contributor

Could you rebase on main? This PR appears to be quite a few commits behind main, which I think is why CI is failing.

@gsganden gsganden requested review from a team as code owners January 30, 2025 23:39
@gsganden gsganden marked this pull request as draft January 30, 2025 23:41
@gsganden gsganden force-pushed the patch-1 branch 2 times, most recently from d93c8aa to a1c003c Compare January 30, 2025 23:54
@gsganden gsganden changed the base branch from dev to main January 30, 2025 23:56
@gsganden gsganden marked this pull request as ready for review January 30, 2025 23:57
@gsganden
Copy link
Contributor Author

Should be fixed now!

@dakinggg dakinggg merged commit 1c20ee4 into mosaicml:main Jan 31, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakinggg dakinggg dakinggg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gsganden @dakinggg