Support bot #378
Merged
Support bot #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ough a look at chatbot can be helpful
…n do primitive retrieval
…nverting jsonl to MDS and uploading it to oci (run locally)
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
dakinggg
reviewed
Aug 23, 2023
There was a problem hiding this comment.
A few high level comments/things to fix in multiple places:
- avoid hardcoded paths/names everywhere (file paths in yamls, endpoints, cluster names, etc)
- please do a pass through the readme and make sure it explains the flow that you want it to. Right now it seems like the code and yaml are written for the 30b but the readme is written for 7b, and there are still a handful of references to the sec 10k example
- all installs of foundry/composer should be pinned to specific commits
- you'll need to run precommit for formatting and type checking, and add your folder to linting () so that it runs in CI
examples/.github/workflows/lint.yaml
Line 29 in 29e298c
examples/end-to-end-examples/support_chatbot/mcli_yamls/deploy_llm.yaml
Outdated
Show resolved
Hide resolved
examples/end-to-end-examples/support_chatbot/mcli_yamls/finetune/finetune_30b_chat.yaml
Outdated
Show resolved
Hide resolved
examples/end-to-end-examples/support_chatbot/mcli_yamls/finetune/finetune_30b_chat.yaml
Outdated
Show resolved
Hide resolved
examples/end-to-end-examples/support_chatbot/mcli_yamls/finetune/finetune_PyPi.yaml
Outdated
Show resolved
Hide resolved
...ples/end-to-end-examples/support_chatbot/mcli_yamls/finetune/finetune_composer_codebase.yaml
Outdated
Show resolved
Hide resolved
…support-bt o /bin/sh: q: command not found
dakinggg
reviewed
Aug 31, 2023
examples/end-to-end-examples/support_chatbot/requirements-cpu.txt
Outdated
Show resolved
Hide resolved
examples/end-to-end-examples/support_chatbot/requirements-cpu.txt
Outdated
Show resolved
Hide resolved
...ples/end-to-end-examples/support_chatbot/mcli_yamls/finetune/finetune_composer_codebase.yaml
Outdated
Show resolved
Hide resolved
...ples/end-to-end-examples/support_chatbot/mcli_yamls/finetune/finetune_composer_codebase.yaml
Outdated
Show resolved
Hide resolved
examples/end-to-end-examples/support_chatbot/mcli_yamls/finetune/finetune_30b_chat.yaml
Outdated
Show resolved
Hide resolved
examples/end-to-end-examples/support_chatbot/scripts/conversion/convert_PyPi_to_stream.py
Outdated
Show resolved
Hide resolved
examples/end-to-end-examples/support_chatbot/custom_mpt_ft_handler.py
Outdated
Show resolved
Hide resolved
dakinggg
reviewed
Aug 31, 2023
examples/end-to-end-examples/support_chatbot/mcli_yamls/convert_checkpoint_to_huggingface.yaml
Outdated
Show resolved
Hide resolved
examples/end-to-end-examples/support_chatbot/mcli_yamls/finetune/finetune_30b_chat.yaml
Outdated
Show resolved
Hide resolved
examples/end-to-end-examples/support_chatbot/mcli_yamls/finetune/finetune_30b_chat.yaml
Outdated
Show resolved
Hide resolved
...ples/end-to-end-examples/support_chatbot/mcli_yamls/finetune/finetune_composer_codebase.yaml
Outdated
Show resolved
Hide resolved
dakinggg
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completed incorporation of MosaicML model and embedding over OpenAI.