Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: modernize dependencies #112

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

seriousme
Copy link
Contributor

@seriousme seriousme commented Feb 27, 2025

This PR closes: #111, it:

  • updates CI
    • to use the lastest versions of NodeJS and actions
    • use docker compose instead of docker-compose which is not supported on Ubuntu:latest action runners anymore
    • uses npm commands to run all tests for more flexibility
  • replaces standard & snappy by eslint & neostandard
  • replaces tape & faucet by node:test
  • removes all unused dependencies
  • updates all dependencies to their latest versions
  • applies various lint fixes
  • removes defunct badges from README.md

Enjoy!

Kind regards,
Hans

@seriousme
Copy link
Contributor Author

Btw: we might want to replace pump and through2 and throughv as well by native node:streams.
I don't know the exact details yet, but it seems doable.

Kind regards,
Hans

@robertsLando
Copy link
Member

Btw: we might want to replace pump and through2 and throughv as well by native node:streams.
I don't know the exact details yet, but it seems doable.

I think I already did this on aedes or mqttjs, do you prefer to go for it here or another PR?

@seriousme
Copy link
Contributor Author

Lets do this in a next PR. Its not an urgent issue for now.

Kind regards,
Hans

@seriousme
Copy link
Contributor Author

hold the press: I found some issues in the new test suite
It turns out that not all tests were executed, its not difficult to fix,but takes some labor.

The good news is that I found it while finalizing the removal of pump and through2 and throughv.

@seriousme
Copy link
Contributor Author

FYI: the process.exit(0) at the end was already part of the original test suite and is required because the abs test did and still does not clean up correctly. I plan on refurbishing the abs test again so that the process.exit(0) is no longer required here.

Comment on lines +13 to +16
obj.on(resolveEvt, () => {
resolve()
})
obj.on('error', reject)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe it's better to use once here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: bump deps and switch to node:test
3 participants