-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add python 3.12 and macOS-13 to test matrix #571
Conversation
The 3.12 tests won't pass until we change the gmso feedstock to pull 3.12 |
for more information, see https://pre-commit.ci
The failing test is caused because The behavior is different between mdtraj 1.9.9 and mdtraj 1.10, but I don't think it's a general bug related to reading bonds from pdb files. If I use the Using mdtraj 1.9.9:
Using mdtraj 1.10.0:
|
Some tests are failing if they use the latest gmso, which has a bug where hoomd needs to be imported for anything using Fix is here: mosdef-hub/gmso#828 |
I feel the amount of CI tests are running out of hand. I gonna reduce the tests matrix down a bit (only do python versions tests on linux and platforms tests on the latest python version). |
That's a good idea! |
This should be implemented now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! We can probably propagate this to mbuild and gmso too
PR Summary:
mBuild and GMSO have started testing with python 3.12 and both versions of MacOS, we should do that here as well.
PR Checklist