Fix bug with finding hoomd minor version when checking for gaff Perio…

…dicImpropers
mosdef-hub · Jun 16, 2024 · b364e48 · b364e48
1 parent 8822524
commit b364e48
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/gmso/external/convert_hoomd.py b/gmso/external/convert_hoomd.py
@@ -1275,7 +1275,7 @@ def _parse_improper_forces(
             base_units,
         )
 
-    if int(hoomd_version[0]) >= 4 and int(hoomd_version[1]) >= 5:
+    if int(hoomd_version[0]) + float(hoomd_version[1]) * 0.1 >= 4.5:
         itype_group_map = {
             "HarmonicImproperPotential": {
                 "container": hoomd.md.improper.Harmonic,

diff --git a/gmso/tests/test_hoomd.py b/gmso/tests/test_hoomd.py
@@ -388,7 +388,8 @@ def test_zero_charges(self):
     @pytest.mark.skipif(not has_hoomd, reason="hoomd is not installed")
     @pytest.mark.skipif(not has_mbuild, reason="mbuild not installed")
     @pytest.mark.skipif(
-        int(hoomd_version[0]) <= 3.8, reason="Deprecated features in HOOMD 4"
+        int(hoomd_version[0]) + float(hoomd_version[1]) * 0.1 < 4.5,
+        reason="Feature added in HOOMD 4.5",
     )
     def test_gaff_sim(self, gaff_forcefield):
         base_units = {