Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PER-44]: IDA performance test scripts and supporting files #1330

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

nihallakshmankonchady
Copy link

The following files are added under this PR.

  1. IDA_Test_Script.jmx : Performance script for IDA
  2. Support files : add_identity_request_details.csv, biometrics_data.txt, center_machine_id_values.csv
  3. README.md : ReadMe file for IDA script execution

@akhilmoogi
Copy link

@nihallakshmankonchady In readme file, mention about the token expiration details.

@akhilmoogi
Copy link

@nihallakshmankonchady In Third Party Certificates (Setup) thread group, check the naming conventions.

Nihal LK added 2 commits September 9, 2024 14:26
@nihallakshmankonchady
Copy link
Author

@akhilmoogi . PR changes were made.

@akhilmoogi
Copy link

@vishwa-vyom Peer review is complete for IDA. Kindly do a final review from your side and merge the PR.

@akhilmoogi
Copy link

S03 Authentication with Demo (Preparation) -> Get Record From ID Repo Endpoint - > Extract Bio Value: variable name is not following naming convention

@akhilmoogi
Copy link

akhilmoogi commented Oct 9, 2024

S02 Authentication with Biometrics (Preparation) - > Loop count is set to 10 any specific reason for that? We need to mention that in the readme file.

This comment was marked as resolved.

This comment was marked as resolved.

Copy link
Member

@vishwa-vyom vishwa-vyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed over call, please check on the below review points.

  1. Use base64 encode and decode to kyc bioauth
  2. addidentitysetup renaming to freshIdentityCreationCount
  3. Maximum and minimum of Counter for different threadgroup
  4. Send OTP link dependency preparation phase
  5. Authdemo and IDA does not need auth token (only identity requires)
  6. No need of calling the get Idrepo since we are using same biometric (Discussion with Varaniya) to avoid pre-requistics -- Authentication with Biometrics
  7. Renaming counter naming
  8. Authentication with demographics with date of birth, name and gender (instead of gender)
  9. Extracted data with lesser size
  10. Add identity in readme file
  11. Reuse same data in readme file
  12. Mention Threadgroup instead of thread and Authentication with Demographics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants