-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PER-44]: IDA performance test scripts and supporting files #1330
base: develop
Are you sure you want to change the base?
[PER-44]: IDA performance test scripts and supporting files #1330
Conversation
Signed-off-by: Nihal LK <[email protected]>
@nihallakshmankonchady In readme file, mention about the token expiration details. |
@nihallakshmankonchady In Third Party Certificates (Setup) thread group, check the naming conventions. |
Signed-off-by: Nihal LK <[email protected]>
Signed-off-by: Nihal LK <[email protected]>
@akhilmoogi . PR changes were made. |
@vishwa-vyom Peer review is complete for IDA. Kindly do a final review from your side and merge the PR. |
Signed-off-by: Nihal LK <[email protected]>
Signed-off-by: Nihal LK <[email protected]>
Signed-off-by: Nihal LK <[email protected]>
S03 Authentication with Demo (Preparation) -> Get Record From ID Repo Endpoint - > Extract Bio Value: variable name is not following naming convention |
S02 Authentication with Biometrics (Preparation) - > Loop count is set to 10 any specific reason for that? We need to mention that in the readme file. |
Signed-off-by: Nihal LK <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Signed-off-by: Nihal LK <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed over call, please check on the below review points.
- Use base64 encode and decode to kyc bioauth
- addidentitysetup renaming to freshIdentityCreationCount
- Maximum and minimum of Counter for different threadgroup
- Send OTP link dependency preparation phase
- Authdemo and IDA does not need auth token (only identity requires)
- No need of calling the get Idrepo since we are using same biometric (Discussion with Varaniya) to avoid pre-requistics -- Authentication with Biometrics
- Renaming counter naming
- Authentication with demographics with date of birth, name and gender (instead of gender)
- Extracted data with lesser size
- Add identity in readme file
- Reuse same data in readme file
- Mention Threadgroup instead of thread and Authentication with Demographics.
The following files are added under this PR.