Cleanup: moves most console log statements into Observability classes #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robacarp
force-pushed
the
adds_mosquito_api
branch
from
c3cd875 to
ffd10ff
Compare
# This is the 1st commit message: moves overseer logging into Observability # The commit message #2 will be skipped: # fixup overseer
robacarp
force-pushed
the
adds_mosquito_api
branch
from
ffd10ff to
86eca0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spent some time cleaning up the Log output, specifically reducing redundant labeling. On the way it became clear that the real place for most of these logs is in the Observability modules, not on the runner itself. This has proven to be a nice refactor, clarifying the purpose of the Observability mobule and distilling the runner logic by removing the fluff required to inform users of the state.
This changes the log output:
The overseer boot message used to be:
INFO - mosquito.runners.overseer.4315742080: Overseer<4315742080> is startingNow the message is simply:
INFO - mosquito.overseer: startingSimilarly, messages from QueueList, Executor, Coordinator, now lack the
.runners.segment of the tag. Where a runner is likely to be the only instance of that runner within a mosquito process (as withoverseerexemplified above) the object id is no longer part of the tag either.