🔨 reverting to for loop

mountainash · May 7, 2024 · b5ee475 · b5ee475
1 parent d2859cf
commit b5ee475
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 8 deletions.
diff --git a/dist/index.js b/dist/index.js
@@ -32647,13 +32647,14 @@ const run = async () => {
 				throw new Error('🛑 ALIAS_DOMAINS should be in array format')
 			}
 
-			ALIAS_DOMAINS.forEach(async (aliasDomain) => {
+			for (let i = 0; i < ALIAS_DOMAINS.length; i++) {
+				const aliasDomain = ALIAS_DOMAINS[i].toLowerCase()
 				core.debug(`🔎 aliasDomain: ${ aliasDomain } (${ typeof aliasDomain })`)
 
 				// check for "falsey" can often be null and empty values
-				if (aliasDomain === '' || aliasDomain.toLowerCase() === 'false' || aliasDomain.toLowerCase() === 'null') {
+				if (aliasDomain === '' || aliasDomain === 'false' || aliasDomain.toLowerCase() === 'null') {
 					core.info(`Skipping ALIAS domain "${ aliasDomain }" 🌐`)
-					return
+					continue
 				}
 
 				const alias = aliasFormatting(aliasDomain)
@@ -32662,7 +32663,7 @@ const run = async () => {
 				await vercel.assignAlias(alias)
 
 				deploymentUrls.push(addSchema(alias))
-			})
+			}
 		}
 
 		deploymentUrls.push(addSchema(deploymentUrl))

diff --git a/src/index.js b/src/index.js
@@ -112,13 +112,14 @@ const run = async () => {
 				throw new Error('🛑 ALIAS_DOMAINS should be in array format')
 			}
 
-			ALIAS_DOMAINS.forEach(async (aliasDomain) => {
+			for (let i = 0; i < ALIAS_DOMAINS.length; i++) {
+				const aliasDomain = ALIAS_DOMAINS[i].toLowerCase()
 				core.debug(`🔎 aliasDomain: ${ aliasDomain } (${ typeof aliasDomain })`)
 
 				// check for "falsey" can often be null and empty values
-				if (aliasDomain === '' || aliasDomain.toLowerCase() === 'false' || aliasDomain.toLowerCase() === 'null') {
+				if (aliasDomain === '' || aliasDomain === 'false' || aliasDomain.toLowerCase() === 'null') {
 					core.info(`Skipping ALIAS domain "${ aliasDomain }" 🌐`)
-					return
+					continue
 				}
 
 				const alias = aliasFormatting(aliasDomain)
@@ -127,7 +128,7 @@ const run = async () => {
 				await vercel.assignAlias(alias)
 
 				deploymentUrls.push(addSchema(alias))
-			})
+			}
 		}
 
 		deploymentUrls.push(addSchema(deploymentUrl))