🐛 better check of "falsey" strings

mountainash · May 7, 2024 · e50a539 · e50a539
1 parent 97a9906
commit e50a539
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 11 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Change Log
 
+## [2.3.3] - 2024-05-07
+
+- BUG: checking for "false" and "null" ALIAS's as strings
+
 ## [2.3.2] - 2024-05-07
 
 - Unique domain added to PR comment

diff --git a/dist/index.js b/dist/index.js
@@ -32641,21 +32641,22 @@ const run = async () => {
 
 		if (ALIAS_DOMAINS.length) {
 			core.info('Assigning alias domains to deployment 🌐')
+			core.debug(`ALIAS_DOMAINS ${ ALIAS_DOMAINS }`)
 
 			if (!Array.isArray(ALIAS_DOMAINS)) {
 				throw new Error('🛑 ALIAS_DOMAINS should be in array format')
 			}
 
-			for (let i = 0; i < ALIAS_DOMAINS.length; i++) {
+			ALIAS_DOMAINS.forEach(async (aliasDomain) => {
 				// check for "falsey" can often be null and empty values
-				if (!ALIAS_DOMAINS[i]) continue
+				if (!aliasDomain || aliasDomain.toLowerCase() === 'false' || aliasDomain.toLowerCase() === 'null') return
 
-				const alias = aliasFormatting(ALIAS_DOMAINS[i])
+				const alias = aliasFormatting(aliasDomain)
 
 				await vercel.assignAlias(alias)
 
 				deploymentUrls.push(addSchema(alias))
-			}
+			})
 		}
 
 		deploymentUrls.push(addSchema(deploymentUrl))

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "deploy-to-vercel-action",
-  "version": "2.3.2",
+  "version": "2.3.3",
   "description": "Deploy your project to Vercel using GitHub Actions. Supports PR previews and GitHub deployments.",
   "type": "commonjs",
   "main": "dist/index.js",

diff --git a/src/index.js b/src/index.js
@@ -106,21 +106,22 @@ const run = async () => {
 
 		if (ALIAS_DOMAINS.length) {
 			core.info('Assigning alias domains to deployment 🌐')
+			core.debug(`ALIAS_DOMAINS ${ ALIAS_DOMAINS }`)
 
 			if (!Array.isArray(ALIAS_DOMAINS)) {
 				throw new Error('🛑 ALIAS_DOMAINS should be in array format')
 			}
 
-			for (let i = 0; i < ALIAS_DOMAINS.length; i++) {
+			ALIAS_DOMAINS.forEach(async (aliasDomain) => {
 				// check for "falsey" can often be null and empty values
-				if (!ALIAS_DOMAINS[i]) continue
+				if (!aliasDomain || aliasDomain.toLowerCase() === 'false' || aliasDomain.toLowerCase() === 'null') return
 
-				const alias = aliasFormatting(ALIAS_DOMAINS[i])
+				const alias = aliasFormatting(aliasDomain)
 
 				await vercel.assignAlias(alias)
 
 				deploymentUrls.push(addSchema(alias))
-			}
+			})
 		}
 
 		deploymentUrls.push(addSchema(deploymentUrl))