Skip to content

Commit

Permalink
use typing.List for hints (data-dot-all#1170)
Browse files Browse the repository at this point in the history
### Feature or Bugfix
- Bugfix

### Detail
Drop hinting as per [PEP585](https://peps.python.org/pep-0585/) and use
typing.List

### Relates
Solves data-dot-all#1167 

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
  • Loading branch information
petrkalos authored Apr 12, 2024
1 parent 01830ac commit 7a4c8a6
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions deploy/stacks/trigger_function_stack.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
from typing import List

from aws_cdk import Duration
from aws_cdk import (
aws_iam as iam,
Expand All @@ -23,7 +25,7 @@ def __init__(
resource_prefix='dataall',
vpc: ec2.IVpc = None,
vpce_connection: ec2.IConnectable = None,
connectables: list[ec2.IConnectable] = [],
connectables: List[ec2.IConnectable] = [],
**kwargs,
):
super().__init__(scope, id, **kwargs)
Expand Down Expand Up @@ -75,7 +77,7 @@ def __init__(
ec2.Peer.any_ipv4(), ec2.Port.tcp(443), 'Allow NAT Internet Access SG Egress'
)

def get_policy_statements(self, resource_prefix) -> list[iam.PolicyStatement]:
def get_policy_statements(self, resource_prefix) -> List[iam.PolicyStatement]:
return [
iam.PolicyStatement(
actions=[
Expand Down

0 comments on commit 7a4c8a6

Please sign in to comment.