Implement Windows testing (#1119)

* add windows tests to test action * test pip install on windows * update us package for 3.12 support * skip failing test on windows --------- Co-authored-by: Shauna Gordon-McKeon <[email protected]>
move-coop · Sep 6, 2024 · 81f622c · 81f622c
1 parent b49a98c
commit 81f622c
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 1 deletion.
diff --git a/.github/workflows/pip-install.yml b/.github/workflows/pip-install.yml
@@ -25,6 +25,7 @@ jobs:
       matrix:
         os:
           - ubuntu-latest
+          - windows-latest
         python-version:
           - "3.12"
           - "3.11"

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -25,6 +25,7 @@ jobs:
       matrix:
         os:
           - ubuntu-latest
+          - windows-latest
         python-version:
           - "3.12"
           - "3.11"
@@ -77,3 +78,4 @@ jobs:
       - name: Format
         run: |
           ruff format --check --diff parsons/ test/ useful_resources/
+
diff --git a/requirements.txt b/requirements.txt
@@ -45,6 +45,6 @@ xmltodict==0.11.0
 # TODO Remove when we have a TMC-specific Docker image
 jinja2>=3.0.2
 selenium==3.141.0
-us==3.1.1
+us==3.2.0
 sshtunnel==0.4.0
 
diff --git a/test/test_targetsmart/test_targetsmart_smartmatch.py b/test/test_targetsmart/test_targetsmart_smartmatch.py
@@ -1,9 +1,11 @@
 import csv
 import io
 import gzip
+import sys
 
 import petl
 import pytest
+
 from parsons.targetsmart.targetsmart_api import TargetSmartAPI
 
 
@@ -70,6 +72,7 @@ def submit_filename():
     return "parsons_test.csv"
 
 
+@pytest.mark.skipif(sys.platform == "win32", reason="need to fix this test on windows")
 def test_smartmatch(
     intable,
     submit_filename,
-Original file line number
+Diff line change
@@ Expand Up / @@ -25,6 +25,7 @@ jobs: @@
           matrix:
             os:
               - ubuntu-latest
+              - windows-latest
             python-version:
               - "3.12"
               - "3.11"
@@ Expand Down @@