Primata/405 move get bridge transfer details

[Primata]

Summary

• RFCs: Get Bridge Details implementation for Move side of the bridge #405
• Categories: protocol-units

Handles move get bridge details by calling view function bridge_transfers(). It takes a bridge_transfer_id variable.

We might want to pay attention since it copy ability had to be added to struct BridgeTransfers

Because bridge_transfer requires a single SmartTable, counterparty had to be refactored.

Changelog

fix init_modules functions
fix tests
complete, refund or cancel bridge transfers do not delete transfers anymore
refactor
bridge_transfers view function to retrieve bridge_transfer details by specifying a transfer id

Testing

Tests are fine.

Outstanding issues

We might want to look to test thoroughly Counterparty modules as they are not completely covered.

[0xmovses]

One question on building the zeroed BridgeTransfer.

[andyjsbell]

Do we want to add copy to this type? Probably a tuple would be a better design here.

[Primata]

@andyjsbell do you mean returning a tuple? Certainly, just wondering how to do that exactly. Any suggestions on how to remove copy are welcome.

[andygolay]

@andyjsbell do you mean returning a tuple? Certainly, just wondering how to do that exactly. Any suggestions on how to remove copy are welcome.

I updated it to return a tuple (see this commit: d90348c). This allows removing the copy and drop ability, which don't really seem like abilities we want for BridgeTransfer.

(I changed the name of bridge_transfers to get_bridge_transfer_from_id to make it describe what the function does.

[andygolay]

LGTM, I made some commits to address review comments by @0xmovses and @andyjsbell and to make CI pass.