Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Key Standard #986

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from
Draft

Key Standard #986

wants to merge 22 commits into from

Conversation

l-monninger
Copy link
Collaborator

@l-monninger l-monninger commented Jan 7, 2025 •
edited by andygolay
Loading

Summary

  • RFCs: PMIP-8
  • Categories: util

Includes the Key Standard for the HSM Demo App. Trace from here to see an example programmatic usage.

To build, run cargo build --release in demo/hsm.

Usage: hsm-demo server ed25519 hashi-corp-vault <CANONICAL_KEY>
Usage: hsm-demo server secp256k1 aws-kms <CANONICAL_KEY>

For example, from the root after building:

./target/release/hsm-demo server secp256k1 aws-kms movement_devNet_fullNode_demoApp_signer_wethTransferSign_replica2

Changelog

Testing

Outstanding issues

@l-monninger l-monninger added the cicd:hsm-demo-containers Builds the HSM demo. label Jan 7, 2025
@0xmovses 0xmovses mentioned this pull request Jan 7, 2025
Open
15 tasks
@l-monninger l-monninger force-pushed the l-monninger/key-spec branch from 1e30cd0 to 99875dc Compare January 7, 2025 23:05
@l-monninger l-monninger added cicd:hsm-demo-containers Builds the HSM demo. and removed cicd:hsm-demo-containers Builds the HSM demo. labels Jan 7, 2025
@andygolay andygolay added cicd:hsm-demo-containers Builds the HSM demo. and removed cicd:hsm-demo-containers Builds the HSM demo. labels Jan 7, 2025
@andygolay andygolay added cicd:hsm-demo-containers Builds the HSM demo. and removed cicd:hsm-demo-containers Builds the HSM demo. labels Jan 8, 2025
@andygolay
Convert DER signature to raw signature for AWS KMS signing (#988)
725bf22 
For now, given Milestone 1 relating to auth rather than key standards, I've changed this PR's purpose to simply adding the DER to raw signature conversion to make signing work with an ARN Key ID as an env var. I'll use @l-monninger and @musitdev's comments on this PR as guidance when we get to integrating Parameter Store for signing.
@andygolay andygolay added cicd:hsm-demo-containers Builds the HSM demo. and removed cicd:hsm-demo-containers Builds the HSM demo. labels Jan 9, 2025
@andygolay andygolay added cicd:hsm-demo-containers Builds the HSM demo. and removed cicd:hsm-demo-containers Builds the HSM demo. labels Jan 9, 2025
@andygolay andygolay added cicd:hsm-demo-containers Builds the HSM demo. and removed cicd:hsm-demo-containers Builds the HSM demo. labels Jan 10, 2025
@andygolay andygolay added cicd:hsm-demo-containers Builds the HSM demo. and removed cicd:hsm-demo-containers Builds the HSM demo. labels Jan 14, 2025
@andygolay andygolay added cicd:hsm-demo-containers Builds the HSM demo. and removed cicd:hsm-demo-containers Builds the HSM demo. labels Jan 15, 2025
@andygolay andygolay added cicd:hsm-demo-containers Builds the HSM demo. and removed cicd:hsm-demo-containers Builds the HSM demo. labels Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xmovses 0xmovses Awaiting requested review from 0xmovses 0xmovses will be requested when the pull request is marked ready for review 0xmovses is a code owner

@mzabaluev mzabaluev Awaiting requested review from mzabaluev mzabaluev will be requested when the pull request is marked ready for review mzabaluev is a code owner

@musitdev musitdev Awaiting requested review from musitdev musitdev will be requested when the pull request is marked ready for review musitdev is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
cicd:hsm-demo-containers Builds the HSM demo.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@l-monninger @andygolay @mzabaluev