-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it more OS independent #11
base: master
Are you sure you want to change the base?
Conversation
The intent of this pull is to streamline the API only make instructions to include it as an option in the download itself.
- Changed 2-spacing to 4-spacing - Make self-consistent indentation
Make indent consistent with PEP-8
Update Makefile to include a "make api" command
Make sed works on both linux and darwin Fix rules in Makefile Use pkg-config to find libusb instead of hard code the path
With these changes are you able to get the NCS to work natively on darwin? |
Can you explain why sed -e is needed on Darwin? I don't have Darwin system but Apple man page https://developer.apple.com/legacy/library/documentation/Darwin/Reference/ManPages/man1/sed.1.html says "Multiple commands may be specified by using the -e or -f options." This agrees with others including Linux man page. I don't see the need for -e as there isn't multiple commands. |
See manpage in MBP. without the -e, the command will be interpret as extension not commend. Adding the -e will work for both linux and darwin. |
I forgot to say thanks for your submissions, so thanks. On Mac OS, sed -i -e 's/\r//' ncsdk.conf creates a backup file ncsdk.conf-e which isn't intended. This has a good description of the issue of sed on Linux vs. Mac OS - in particular the comment on using the sedi function to switch options based. However, I'm not sure how to do that from within a Makefile. sedi () { |
Any chance for this to get merged in soon? It would be great to be able to develop code targeting NCS using macOS. |
I was working on getting everything setup on macOS independently when I found this... I think there is still a lot of work to be done here. Running In Things really get out of hand when the Makefile calls
If you fix that by replacing Thats where I stopped. If you want to get this working on macOS you're in for another 600 lines of bash just to get through I personally don't have the time (or feel like) going through this, but if I do, I'll be sure to report back to you all. Edit: |
I got |
Make sed works on both linux and darwin
Fix rules in Makefile
Use pkg-config to find libusb instead of hard code the path