Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(colors): update to use default colors #96

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CoryWritesCode
Copy link

Adding default colors behaves the way it would seem when initially setting up the project.
Let me know if this isn't something you want in here, it just seems like it should have defaults when you see the image initially and then set it up to see no colors out of the box.

image

fixes #95

@CoryWritesCode
Copy link
Author

@alessandro-bottamedi this project still being maintained? See a few PRs need attention.

@alessandro-bottamedi
Copy link
Collaborator

Sorry, I’ve been very busy, but I’ll have time to check everything after October 15th! I’ll then release a new version with some of the PRs included…

@alessandro-bottamedi
Copy link
Collaborator

Hi, currently the colors are optional, messages are colored only if the colors option in the transport is filled in, also based on custom levels. I would prefer to leave it like this, maybe specifying it better in the readme? It seems cleaner to me to leave the transport options always empty by default... What's your opinion? @CoryWritesCode

@CoryWritesCode
Copy link
Author

CoryWritesCode commented Nov 10, 2024

I think thats fine! It just didn't make sense to try what you mentioned in my Issue per the readme. The only issue I would think is that the first image of the lib shows colorization of the logs which made me think that it's available out of the box. So it should probably should be stated better in the readme at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logs are not showing color on metro bundler for React native
2 participants