Change the way we decide if a property is present from entrypoint con…

…fig (#640)
mozilla-ai · Jan 15, 2025 · 906ed45 · 906ed45
1 parent f39e56f
commit 906ed45
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/lumigator/frontend/src/helpers/index.js b/lumigator/frontend/src/helpers/index.js
@@ -39,23 +39,23 @@ export function retrieveEntrypoint(job) {
     // See: lumigator/python/mzai/backend/backend/config_templates.py
 
     // Normalize the max_samples
-    if (jsonObject?.job?.max_samples) {
+    if (jsonObject?.job?.max_samples !== undefined) {
       jsonObject.max_samples = jsonObject.job.max_samples;
-    } else if (jsonObject?.evaluation?.max_samples) {
+    } else if (jsonObject?.evaluation?.max_samples !== undefined) {
       jsonObject.max_samples = jsonObject.evaluation.max_samples;
     } else {
       throw new Error("Unable to parse max_samples from entrypoint config: " + configString);
     }
 
     // Normalize the model path
     let modelPath = '';
-    if (jsonObject?.model?.path) {
+    if (jsonObject?.model?.path !== undefined) {
       modelPath = jsonObject.model.path;
-    } else if (jsonObject?.model?.inference?.engine) {
+    } else if (jsonObject?.model?.inference?.engine !== undefined) {
       modelPath = jsonObject.model.inference.engine;
-    } else if (jsonObject?.hf_pipeline?.model_uri) {
+    } else if (jsonObject?.hf_pipeline?.model_uri !== undefined) {
       modelPath = jsonObject.hf_pipeline.model_uri;
-    } else if (jsonObject?.inference_server?.engine) {
+    } else if (jsonObject?.inference_server?.engine !== undefined) {
       modelPath = jsonObject.inference_server.engine;
     } else {
       throw new Error("Unable to parse model path from entrypoint config: " + configString);