Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add postgres helm chart as dependency #203

Merged
merged 10 commits into from
Jan 10, 2025
Merged

Add postgres helm chart as dependency #203

merged 10 commits into from
Jan 10, 2025

Conversation

chainlink
Copy link
Member

@chainlink chainlink commented Sep 9, 2024

Description

This adds the bitnami postgres chart to Lumigator. It vendors (commits) the subchart for easy install (no helm dep required)

This installs postgres by default when installing via helm for kubernetes.

This does not allow for passing in an existing postgres installation, that option will be added in a future PR.

Other cleanup:

This cleans up old postgres vars present in the code but unused

To test

helm install lumigator lumigator --set image.tag=backend_dev_ -f cw-values.yaml

cw-values.yaml



global:
  storageClass: shared-vast # For Postgresql

s3Bucket: "lumigator-ktest"
AWSAccessKey: "<redacted>"
AWSSecretKey: "<redacted>"
s3EndpointURL: "https://object.lga1.coreweave.com"
AWSEndpointURL: "https://object.lga1.coreweave.com"

rayAddress: "ray-lumigator-head-svc"
rayPort: "8265"
rayWorkerGPUs: "1.0"

# Note: Need to manually delete PVC after helm delete
postgresql:
  primary:
    initContainers:
      - command:
          - sh
          - -c
          - |
            uid
            mkdir -p $VOLUME_DATA_DIR
            chown -R 1001:1001 $VOLUME_DATA_DIR
            echo 'Volume permissions OK ✓'
        env:
          - name: VOLUME_DATA_DIR
            value: /bitnami/postgresql
        image: busybox
        imagePullPolicy: IfNotPresent
        name: volumepermissions
        securityContext:
          runAsUser: 0
        volumeMounts:
          - mountPath: /bitnami/postgresql
            name: data

Testing

  • Tested and working on coreweave

@agpituk agpituk mentioned this pull request Dec 2, 2024
1 task
@github-actions github-actions bot added backend documentation Improvements or additions to documentation labels Jan 6, 2025
@chainlink chainlink requested review from peteski22 and agpituk January 6, 2025 17:53
@chainlink chainlink marked this pull request as ready for review January 6, 2025 17:54
Copy link
Contributor

@javiermtorres javiermtorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's the annoying issue about the huge_pages=off setting in some deployments :-/ Is it worth it to add the details to some of the readme files?

@chainlink
Copy link
Member Author

There's the annoying issue about the huge_pages=off setting in some deployments :-/ Is it worth it to add the details to some of the readme files?

Can you elaborate?

@chainlink chainlink requested a review from macaab26 January 9, 2025 19:31
@javiermtorres
Copy link
Contributor

Can you elaborate?

There's some info on this issue here: bitnami/charts#7901
I'd assume any usual cloud provider would provide hosts with huge pages support out of the box, if you didn't hit this issue.

@chainlink chainlink merged commit 2ca0610 into main Jan 10, 2025
9 checks passed
@chainlink chainlink deleted the helm-pg-new branch January 10, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants