Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix for container stop in tests #591

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Hotfix for container stop in tests #591

merged 1 commit into from
Jan 10, 2025

Conversation

javiermtorres
Copy link
Contributor

What's changing

The KEEP_CONTAINERS_UP env var did not work correctly.

How to test it

With the default config in main, use make test-sdk-integration. The containers will not stop after tests.

Additional notes for reviewers

N/A

I already...

  • Tested the changes in a working environment to ensure they work as expected
  • Added some tests for any new functionality
  • Updated the documentation (both comments in code and product documentation under /docs)
  • Checked if a (backend) DB migration step was required and included it if required

@javiermtorres javiermtorres marked this pull request as ready for review January 10, 2025 09:25
@javiermtorres javiermtorres merged commit c8726c3 into main Jan 10, 2025
10 checks passed
@javiermtorres javiermtorres deleted the javiermtorres/hotfix-containers-up branch January 10, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteski22 peteski22 peteski22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@javiermtorres @peteski22