-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: crash if requested output field for inference doesn't exist in dataset #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
ividal
force-pushed
the
585-output-field
branch
2 times, most recently
from
January 15, 2025 00:06
aaba0d0
to
fdd7ddc
Compare
ividal
force-pushed
the
585-output-field
branch
from
January 16, 2025 09:30
fdd7ddc
to
47b9804
Compare
ividal
force-pushed
the
585-output-field
branch
from
January 16, 2025 11:01
47b9804
to
4f86d11
Compare
|
ividal
force-pushed
the
585-output-field
branch
from
January 16, 2025 11:03
4f86d11
to
e103495
Compare
aittalam
approved these changes
Jan 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TY Irina for this PR!
I left a couple of minor comments but once they are addressed (and code from main is merged again 😅) this LGTM 🙏
ividal
force-pushed
the
585-output-field
branch
from
January 16, 2025 14:52
e103495
to
b9f096a
Compare
ividal
force-pushed
the
585-output-field
branch
from
January 16, 2025 20:51
ca59ec3
to
8bdb636
Compare
javiermtorres
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changing
If a field is requested for outputs and it doesn't exist in the input dataset (which is to be expected), inference crashes (and, by extension, so does annotation).
This PR:
Closes #585
How to test it
Steps to test the changes:
Additional notes for reviewers
This changes the previous behaviour of keeping whatever was in the existing column (which meant we did inference for nothing if there were already predictions/annotations there).
I already...
/docs
)