Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC] Remove unused package-lock files #636

Merged
merged 3 commits into from
Jan 23, 2025
Merged

[NFC] Remove unused package-lock files #636

merged 3 commits into from
Jan 23, 2025

Conversation

njbrake
Copy link
Contributor

@njbrake njbrake commented Jan 15, 2025 •
edited by javiermtorres
Loading

What's changing

Removed a few files that aren't used anymore by the frontend.

If this PR is related to an issue or closes one, please link it here.

How to test it

make local-up observe everything still loads.

Additional notes for reviewers

n/a

I already...

  • Tested the changes in a working environment to ensure they work as expected
  • Added some tests for any new functionality
  • Updated the documentation (both comments in code and product documentation under /docs)
  • Checked if a (backend) DB migration step was required and included it if required

@njbrake njbrake requested a review from george-mzai January 15, 2025 18:37
@njbrake njbrake marked this pull request as ready for review January 15, 2025 18:37
@njbrake njbrake merged commit 11c23f5 into main Jan 23, 2025
13 checks passed
@njbrake njbrake deleted the brake/node_cleanup branch January 23, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@george-mzai george-mzai george-mzai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@njbrake @george-mzai