Add detailed experiment status #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
backend
api
|
Note: this PR is based on #604 . The real amount of files changed is much smaller. Please don't review until this other PR is merged. |
javiermtorres
changed the title
javiermtorres
force-pushed
the
issue-571-add-experiment-status
branch
from
43fc199 to
fd4da0b
Compare
aittalam
reviewed
Jan 21, 2025
aittalam
reviewed
Jan 21, 2025
aittalam
requested changes
Jan 21, 2025
There was a problem hiding this comment.
TY @javiermtorres ! I added minor fixes to be applied before merging.
Blocking this just because I want to make sure the above are already covered by tests before merging, but if you can confirm this I am happy to approve it!
ividal
reviewed
Jan 22, 2025
Co-authored-by: Davide Eynard <[email protected]> Signed-off-by: javiermtorres <[email protected]>
javiermtorres
force-pushed
the
issue-571-add-experiment-status
branch
from
7f1f9ed to
80c57e4
Compare
aittalam
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
TY @javiermtorres for implementing the new logic!
This looks good to me, I am happy to preapprove it. Re: impact on the current UI, there will be none as this service is hit only by the new endpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changing
Adds detailed experiment status depending on the component job status.
Closes #571
How to test it
Integration tests are supplied with the change. Manually, the status can be retrieved and checked while the component jobs are cycling through their RUNNING and SUCCEEDED/FAILED status.
Additional notes for reviewers
N/A
I already...
/docs)