Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove models that don't support generic summaries. #673

Merged

Conversation

njbrake
Copy link
Contributor

@njbrake njbrake commented Jan 17, 2025

What's changing

Remove the two models that don't perform well on generic summarization tasks.

If this PR is related to an issue or closes one, please link it here.
Closes #621

How to test it

Steps to test the changes:

  1. make local-up
  2. Open lumigator, add dataset, run experiment, observe that that mikeadimech/longformer-qmsum-meeting-summarization and mrm8488/t5-base-finetuned-summarize-news are gone.

Additional notes for reviewers

I already...

  • [ x] Tested the changes in a working environment to ensure they work as expected
  • Added some tests for any new functionality
  • [x ] Updated the documentation (both comments in code and product documentation under /docs)
  • [x ] Checked if a (backend) DB migration step was required and included it if required

@njbrake njbrake linked an issue Jan 17, 2025 that may be closed by this pull request
@github-actions github-actions bot added documentation Improvements or additions to documentation sdk backend labels Jan 17, 2025
@njbrake njbrake marked this pull request as ready for review January 17, 2025 18:41
@njbrake njbrake requested review from ividal and veekaybee January 17, 2025 18:41
@veekaybee
Copy link
Member

Did a git grep and checked for these, looks great, thanks!

@njbrake njbrake merged commit 5b4275b into main Jan 17, 2025
14 checks passed
@njbrake njbrake deleted the 621-remove-models-that-do-not-supply-reasonable-summaries branch January 17, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend documentation Improvements or additions to documentation sdk
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Models that do not supply reasonable summaries
2 participants