Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Job name instead of a reference to the address in memory. #677

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

njbrake
Copy link
Contributor

@njbrake njbrake commented Jan 17, 2025

What's changing

Use the record's name, because otherwise it logs the class name and memory address.

Before change:

.....- Obtaining info for job ca7c4a26-2c45-4e8e-9ce6-ae1abc9b2a49: <backend.records.jobs.JobRecord object at 0xffff713e8a90>

After Change

....- Obtaining info for job ca7c4a26-2c45-4e8e-9ce6-ae1abc9b2a49: nathans_job

How to test it

Steps to test the changes:

  1. make local-up
  2. upload dataset
  3. trigger a job, and look at the backend logs.

I already...

  • Tested the changes in a working environment to ensure they work as expected
  • Added some tests for any new functionality
  • Updated the documentation (both comments in code and product documentation under /docs)
  • Checked if a (backend) DB migration step was required and included it if required

@njbrake njbrake marked this pull request as ready for review January 17, 2025 20:26
@njbrake njbrake requested a review from veekaybee January 17, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant