Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SDK to use new workflows API #783

Merged
merged 55 commits into from
Feb 5, 2025
Merged

Update SDK to use new workflows API #783

merged 55 commits into from
Feb 5, 2025

Conversation

njbrake
Copy link
Contributor

@njbrake njbrake commented Jan 31, 2025

What's changing

Following #768 , the experiments + workflow API is ready for use. This PR updates the SDK to use the new endpoints, and also adds an integration test to make sure the SDK can properly create an experiment and workflows under the experiment.

If this PR is related to an issue or closes one, please link it here.

Refs #758

How to test it

This should be handled by the integration tests, but you can test it with whatever applications you use that use the SDK (not sure what those are atm)

Additional notes for reviewers

Anything you'd like to add to help the reviewer understand the changes you're proposing.

I already...

  • Tested the changes in a working environment to ensure they work as expected
  • Added some tests for any new functionality
  • Updated the documentation (both comments in code and product documentation under /docs)
  • Checked if a (backend) DB migration step was required and included it if required

njbrake and others added 30 commits January 23, 2025 14:46
@njbrake njbrake marked this pull request as ready for review January 31, 2025 16:09
Copy link
Contributor

@javiermtorres javiermtorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from 527-mlflow-implementation to main February 5, 2025 20:39
@njbrake njbrake merged commit 9c2fe5b into main Feb 5, 2025
15 checks passed
@njbrake njbrake deleted the brake/sdk_update branch February 5, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants