tests: cleanup tests (bug 1944851) (#213)

- tests are passing and should have been unmarked some time ago
mozilla-conduit · Jan 30, 2025 · 498a7ff · 498a7ff
1 parent 7392be9
commit 498a7ff
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 8 deletions.
diff --git a/src/lando/api/tests/test_hooks.py b/src/lando/api/tests/test_hooks.py
@@ -19,7 +19,7 @@ def test_app_wide_headers_set(client):
 
 
 # See bug 1927163.
-@pytest.mark.xfail
+@pytest.mark.xfail(strict=True)
 @pytest.mark.django_db
 def test_app_wide_headers_set_for_api_endpoints(client):
     response = client.get("/__version__")

diff --git a/src/lando/api/tests/test_landings.py b/src/lando/api/tests/test_landings.py
@@ -1032,8 +1032,6 @@ def test_format_patch_no_landoini(
     ), "Successful landing should trigger Phab repo update."
 
 
-# bug 1893453
-@pytest.mark.xfail
 @pytest.mark.django_db
 def test_landing_job_revisions_sorting(
     create_patch_revision,

diff --git a/src/lando/api/tests/test_transplants.py b/src/lando/api/tests/test_transplants.py
@@ -327,8 +327,6 @@ def test_dryrun_outside_codefreeze(
     assert not response.json["warnings"]
 
 
-# auth related issue, blockers empty.
-@pytest.mark.xfail
 @pytest.mark.parametrize(
     "permissions,status,blocker",
     [
@@ -645,8 +643,6 @@ def test_confirmation_token_warning_order():
     )
 
 
-# bug 1893453.
-@pytest.mark.xfail
 @pytest.mark.django_db(transaction=True)
 def test_integrated_transplant_simple_stack_saves_data_in_db(
     app,

diff --git a/src/lando/api/tests/test_uplift.py b/src/lando/api/tests/test_uplift.py
@@ -85,7 +85,7 @@ def test_strip_depends_on_from_commit_message():
     ), "`Depends on` line should be stripped from commit message."
 
 
-@pytest.mark.xfail
+@pytest.mark.xfail(strict=True)
 def test_uplift_creation(
     db,
     monkeypatch,