diff_warnings: port functionality (bug 1941342) #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
zzzeid
commented
Jan 17, 2025
•
zzzeid
commented
- port diff warnings endpoint handling
- unskip tests
- update tests, views, forms to work with new implementation
- rename diff_warning.error_breakdown back to diff_warning.data
zzzeid
force-pushed
the
zeid/bug-1941342-diff_warnings
branch
4 times, most recently
from
43d9e53 to
e45d7fa
Compare
zzzeid
force-pushed
the
zeid/bug-1941342-diff_warnings
branch
from
e45d7fa to
54a203d
Compare
zzzeid
requested review from
shtrom and
cgsheeh
and removed request for
shtrom
shtrom
approved these changes
Jan 21, 2025
|
|
||
| @wraps(func) | ||
| def _wrapper(self, request, *args, **kwargs): | ||
| HEADER = "X-Phabricator-Api-Key" |
There was a problem hiding this comment.
Should it be HTTP_X_Phabricator_API_Key now, as in the test fixtures? https://github.com/mozilla-conduit/lando/pull/197/files#diff-3f084e2a5f612fc35bc5c68a611d1ad8959f632315c6e9115149298061dcc371R15
Comment on lines
+87
to
+88
| else: | ||
| return JsonResponse({"errors": dict(form.errors)}, status=400) |
There was a problem hiding this comment.
Suggested change
| else: | |
| return JsonResponse({"errors": dict(form.errors)}, status=400) | |
| return JsonResponse({"errors": dict(form.errors)}, status=400) |
Comment on lines
+110
to
+111
| else: | ||
| return JsonResponse({"errors": dict(form.errors)}, status=400) |
There was a problem hiding this comment.
Suggested change
| else: | |
| return JsonResponse({"errors": dict(form.errors)}, status=400) | |
| return JsonResponse({"errors": dict(form.errors)}, status=400) |
Comment on lines
-149
to
154
| "id": self.id, | ||
| "diff_id": self.diff_id, | ||
| "group": self.group, | ||
| "id": self.id, | ||
| "revision_id": self.revision_id, | ||
| "status": self.status.value, | ||
| "group": self.group.value, | ||
| "status": self.status, | ||
| "data": self.data, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.