Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: handle skipped tests (bug 1897504) #198

Merged
merged 3 commits into from
Jan 24, 2025

Conversation

zzzeid
Copy link
Collaborator

@zzzeid zzzeid commented Jan 20, 2025

  • fix landing job cancel tests
  • remove unneeded phabricator exception test
  • fix bug in JS code that called endpoint without trailing slash

@zzzeid zzzeid marked this pull request as ready for review January 20, 2025 19:21
@zzzeid zzzeid marked this pull request as draft January 20, 2025 19:30
- fix landing job cancel tests
- remove unneeded phabricator exception test
- return json response for 403/404
@zzzeid zzzeid force-pushed the zeid/bug-1897504-handle-skipped-tests branch from 0772471 to 98753d9 Compare January 20, 2025 19:48
@zzzeid zzzeid marked this pull request as ready for review January 20, 2025 19:52
@zzzeid zzzeid requested review from shtrom and cgsheeh January 20, 2025 19:52
Copy link
Member

@shtrom shtrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zzzeid zzzeid requested a review from cgsheeh January 23, 2025 16:10
@zzzeid zzzeid merged commit 76a6c2c into main Jan 24, 2025
1 check passed
@zzzeid zzzeid deleted the zeid/bug-1897504-handle-skipped-tests branch January 24, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants